* bug#23617: 25.1.50; Ibuffer in other window
@ 2016-05-25 15:22 Tino Calancha
[not found] ` <handler.23617.B.14641895863618.ack@debbugs.gnu.org>
0 siblings, 1 reply; 6+ messages in thread
From: Tino Calancha @ 2016-05-25 15:22 UTC (permalink / raw)
To: 23617
Sometimes Ibuffer is shown in the selected window even
though OTHER-WINDOW-P non-nil.
./emacs -Q -mm -eval '(split-window-right)'
C-u M-x ibuffer RET
;; Ibuffer appears in the right hand side
RET
C-u M-x ibuffer RET
;; Again Ibuffer appears in the right hand side,
;; but this time it should appeared in the left.
In GNU Emacs 25.1.50.5 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30)
Repository revision: 1ee91bf89176251f6e399c8436dca0248cdd6f6b
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23617: PATCH (25.1.50; Ibuffer in other window)
[not found] ` <handler.23617.B.14641895863618.ack@debbugs.gnu.org>
@ 2016-05-25 15:30 ` Tino Calancha
2016-06-08 0:36 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Tino Calancha @ 2016-05-25 15:30 UTC (permalink / raw)
To: 23617
From 67500ceb4a0ea5923b3b9f2e1fef4161150c7c96 Mon Sep 17 00:00:00 2001
From: Tino Calancha <f92capac@gmail.com>
Date: Thu, 26 May 2016 00:22:42 +0900
Subject: [PATCH] Ibuffer in other window
* lisp/ibuffer.el (ibuffer): Use other window when OTHER-WINDOW-P
non-nil (Bug#23617).
---
lisp/ibuffer.el | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index dd2687c..d78a8f4 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -2341,8 +2341,10 @@ ibuffer
(setq other-window-p t))
(let ((buf (get-buffer-create (or name "*Ibuffer*"))))
(if other-window-p
- (funcall (if noselect (lambda (buf) (display-buffer buf t)) #'pop-to-buffer) buf)
- (funcall (if noselect #'display-buffer #'switch-to-buffer) buf))
+ (funcall (lambda (x) (or (and noselect (display-buffer x t))
+ (pop-to-buffer x t))) buf)
+ (funcall (or (and noselect #'display-buffer)
+ #'switch-to-buffer) buf))
(with-current-buffer buf
(save-selected-window
;; We switch to the buffer's window in order to be able
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#23617: PATCH (25.1.50; Ibuffer in other window)
2016-05-25 15:30 ` bug#23617: PATCH (25.1.50; Ibuffer in other window) Tino Calancha
@ 2016-06-08 0:36 ` Glenn Morris
2016-10-17 7:48 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2016-06-08 0:36 UTC (permalink / raw)
To: 23617-done
Version: 25.2
Thanks; applied with minor change.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23617: PATCH (25.1.50; Ibuffer in other window)
2016-06-08 0:36 ` Glenn Morris
@ 2016-10-17 7:48 ` Eli Zaretskii
2016-10-17 15:56 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2016-10-17 7:48 UTC (permalink / raw)
To: 23617
> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 07 Jun 2016 20:36:16 -0400
>
> Version: 25.2
>
> Thanks; applied with minor change.
Any reason why you cherry-picked that from master to the release
branch? IOW, why does this fix have to be in 25.2, which is supposed
to b a bug-fix only release?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23617: PATCH (25.1.50; Ibuffer in other window)
2016-10-17 7:48 ` Eli Zaretskii
@ 2016-10-17 15:56 ` Glenn Morris
2016-10-17 16:14 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2016-10-17 15:56 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 23617
Eli Zaretskii wrote:
>> From: Glenn Morris <rgm@gnu.org>
>> Date: Tue, 07 Jun 2016 20:36:16 -0400
>>
>> Version: 25.2
>>
>> Thanks; applied with minor change.
>
> Any reason why you cherry-picked that from master to the release
> branch?
It's a trivial bug fix / harmless improvement, which I had marked as
fixed in 25.2, and personally I think such meta-data is important.
It was that or change the bug fixed version, frankly this was less work.
Same for the other two.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23617: PATCH (25.1.50; Ibuffer in other window)
2016-10-17 15:56 ` Glenn Morris
@ 2016-10-17 16:14 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-10-17 16:14 UTC (permalink / raw)
To: Glenn Morris; +Cc: 23617
> From: Glenn Morris <rgm@gnu.org>
> Cc: 23617@debbugs.gnu.org
> Date: Mon, 17 Oct 2016 11:56:13 -0400
>
> > Any reason why you cherry-picked that from master to the release
> > branch?
>
> It's a trivial bug fix / harmless improvement, which I had marked as
> fixed in 25.2, and personally I think such meta-data is important.
> It was that or change the bug fixed version, frankly this was less work.
> Same for the other two.
If that's the reason, please revert them. They don't fit the purpose
of the 25.2 release, which is ti be a bug-fix only release to be put
out the door as quickly as we can.
For future reference, I tried to describe what should go into emacs-25
here:
http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00007.html
No one objected, so I guess these should be our criteria for 25.2.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-17 16:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 15:22 bug#23617: 25.1.50; Ibuffer in other window Tino Calancha
[not found] ` <handler.23617.B.14641895863618.ack@debbugs.gnu.org>
2016-05-25 15:30 ` bug#23617: PATCH (25.1.50; Ibuffer in other window) Tino Calancha
2016-06-08 0:36 ` Glenn Morris
2016-10-17 7:48 ` Eli Zaretskii
2016-10-17 15:56 ` Glenn Morris
2016-10-17 16:14 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).