unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rms@gnu.org
Cc: anticrisisg@gmail.com, larsi@gnus.org, 44834@debbugs.gnu.org,
	dgutov@yandex.ru
Subject: bug#44834: Fix for failing indentation of Tcl procs nested in namespace
Date: Thu, 11 Feb 2021 16:39:46 +0200	[thread overview]
Message-ID: <83v9ayhdn1.fsf@gnu.org> (raw)
In-Reply-To: <E1lACBc-0000eU-C1@fencepost.gnu.org> (message from Richard Stallman on Thu, 11 Feb 2021 08:39:12 -0500)

> From: Richard Stallman <rms@gnu.org>
> Cc: larsi@gnus.org, anticrisisg@gmail.com, 44834@debbugs.gnu.org,
> 	dgutov@yandex.ru
> Date: Thu, 11 Feb 2021 08:39:12 -0500
> 
>   >   I agree that in
>   > principle "new or modified" covers that, but how many readers will
>   > immediately understand that "modified" doesn't include "deleted"?
> 
> The idea is to count lines in the new version which are added or
> modified.  If that is clear, you will see that it doesn't count
> anything from the old versin.

The problem is that most modern comparison tools show diffs where
there are no "changed" lines (the "!" mark of "diff -c"), they only
show "-" and "+", i.e. as if the edit distance is a sequence of just 2
operations: delete and add.  So "changed" doesn't have a clear and
immediate interpretation in terms of the presentation in diffs.

> If that is not clear, we do need to clarify it.  But real
> clarification calls for more than "deleted lines don't count".  It's,
> "Don't count _anything_ from the old code; count only the added and
> modified lines in the _patched_ code."

That's clear enough.  How about this text:

  Once the cumulative amount of your submissions exceeds about 10 lines
  of non-trivial changes, we will need you to assign to the FSF the
  copyright for your contributions.  (To see how many lines were
  non-trivially changed, count only added and modified lines in the
  patched code.  An added or changed line is non-trivial if it includes
  at least one identifier.)  Ask on emacs-devel@gnu.org, and we will
  send you the necessary form together with the instructions to fill and
  email it, in order to start this legal paperwork.





  parent reply	other threads:[~2021-02-11 14:39 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 23:58 bug#44834: 27.1; Tcl mode enforces bad indentation following proc within a namespace Morgan Willcock
2021-01-08 22:21 ` bug#44834: change severity Anticrisis
2021-01-08 23:04 ` bug#44834: Patch to provide failing test for bug 44834 Anticrisis
2021-01-09  1:24   ` Anticrisis
2021-01-10 12:10     ` Lars Ingebrigtsen
2021-01-10 18:41       ` Anticrisis
2021-01-11 15:17         ` Lars Ingebrigtsen
2021-01-22  1:17 ` bug#44834: Fix for failing indentation of Tcl procs nested in namespace Anticrisis
2021-01-27  4:37   ` Lars Ingebrigtsen
2021-02-06 21:51     ` Anticrisis
2021-02-07  5:47       ` Richard Stallman
2021-02-07  7:26         ` Anticrisis
2021-02-06 22:55     ` Dmitry Gutov
2021-02-07  5:47       ` Richard Stallman
2021-02-07 11:40         ` Lars Ingebrigtsen
2021-02-08  3:44           ` Richard Stallman
2021-02-08  6:30             ` Lars Ingebrigtsen
2021-02-09  6:07               ` Richard Stallman
2021-02-09  8:24                 ` Lars Ingebrigtsen
2021-02-09 15:40                   ` Eli Zaretskii
2021-02-10  5:32                     ` Richard Stallman
2021-02-10 15:08                       ` Eli Zaretskii
2021-02-11 13:39                         ` Richard Stallman
2021-02-11 14:00                           ` Lars Ingebrigtsen
2021-02-11 14:39                           ` Eli Zaretskii [this message]
2021-02-12  5:48                             ` Richard Stallman
2021-02-12  5:48                             ` Richard Stallman
2021-02-12  7:26                               ` Eli Zaretskii
2021-02-12  8:14                             ` Lars Ingebrigtsen
2021-02-12 11:16                               ` Eli Zaretskii
2021-02-13  3:26                               ` Richard Stallman
2021-02-13 11:37                                 ` Lars Ingebrigtsen
2021-02-13 12:25                                 ` Dmitry Gutov
2021-02-16  5:19                                   ` Richard Stallman
2021-02-16 12:05                                     ` Dmitry Gutov
2021-02-16 12:06                                       ` Lars Ingebrigtsen
2021-02-16 15:38                                         ` Eli Zaretskii
2021-02-16 16:29                                           ` Lars Ingebrigtsen
2021-02-16 17:15                                           ` Juri Linkov
2021-02-16 18:53                                             ` Eli Zaretskii
2021-02-18  6:12                                             ` Richard Stallman
2021-02-18 14:08                                               ` Eli Zaretskii
2021-02-18 14:15                                           ` Dmitry Gutov
2021-02-17  4:12                                         ` Richard Stallman
2021-02-10 15:24                       ` Lars Ingebrigtsen
2021-02-10 16:03                         ` Matt Armstrong
2021-02-11 13:39                         ` Richard Stallman
2021-02-11 14:41                           ` Eli Zaretskii
2021-02-11 14:49                             ` Dmitry Gutov
2021-02-12  5:48                             ` Richard Stallman
2021-01-22 19:37 ` bug#44834: Patch also closes bug#44083 Anticrisis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v9ayhdn1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=44834@debbugs.gnu.org \
    --cc=anticrisisg@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).