From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44834: Fix for failing indentation of Tcl procs nested in namespace Date: Thu, 11 Feb 2021 16:39:46 +0200 Message-ID: <83v9ayhdn1.fsf@gnu.org> References: <87sg8zk4lj.fsf@precedence.co.uk> <87k0rzatbp.fsf@gnus.org> <87h7mo85t6.fsf@gnus.org> <8735y7nk9z.fsf@gnus.org> <87h7mlk5re.fsf@gnus.org> <8335y5l059.fsf@gnu.org> <837dngj6yp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32827"; mail-complaints-to="usenet@ciao.gmane.io" Cc: anticrisisg@gmail.com, larsi@gnus.org, 44834@debbugs.gnu.org, dgutov@yandex.ru To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 11 15:41:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAD9Z-0008R4-SN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Feb 2021 15:41:09 +0100 Original-Received: from localhost ([::1]:48718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAD9Y-0001EH-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Feb 2021 09:41:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAD9S-0001D5-4x for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2021 09:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAD9R-0001U2-U1 for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2021 09:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAD9R-0001CO-QY for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2021 09:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Feb 2021 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44834 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 44834-submit@debbugs.gnu.org id=B44834.16130544044521 (code B ref 44834); Thu, 11 Feb 2021 14:41:01 +0000 Original-Received: (at 44834) by debbugs.gnu.org; 11 Feb 2021 14:40:04 +0000 Original-Received: from localhost ([127.0.0.1]:58092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAD8V-0001Aq-EA for submit@debbugs.gnu.org; Thu, 11 Feb 2021 09:40:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAD8R-0001AH-WF for 44834@debbugs.gnu.org; Thu, 11 Feb 2021 09:40:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42721) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAD8K-0000tC-QT; Thu, 11 Feb 2021 09:39:52 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3549 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lAD8C-0004vr-4C; Thu, 11 Feb 2021 09:39:44 -0500 In-Reply-To: (message from Richard Stallman on Thu, 11 Feb 2021 08:39:12 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199814 Archived-At: > From: Richard Stallman > Cc: larsi@gnus.org, anticrisisg@gmail.com, 44834@debbugs.gnu.org, > dgutov@yandex.ru > Date: Thu, 11 Feb 2021 08:39:12 -0500 > > > I agree that in > > principle "new or modified" covers that, but how many readers will > > immediately understand that "modified" doesn't include "deleted"? > > The idea is to count lines in the new version which are added or > modified. If that is clear, you will see that it doesn't count > anything from the old versin. The problem is that most modern comparison tools show diffs where there are no "changed" lines (the "!" mark of "diff -c"), they only show "-" and "+", i.e. as if the edit distance is a sequence of just 2 operations: delete and add. So "changed" doesn't have a clear and immediate interpretation in terms of the presentation in diffs. > If that is not clear, we do need to clarify it. But real > clarification calls for more than "deleted lines don't count". It's, > "Don't count _anything_ from the old code; count only the added and > modified lines in the _patched_ code." That's clear enough. How about this text: Once the cumulative amount of your submissions exceeds about 10 lines of non-trivial changes, we will need you to assign to the FSF the copyright for your contributions. (To see how many lines were non-trivially changed, count only added and modified lines in the patched code. An added or changed line is non-trivial if it includes at least one identifier.) Ask on emacs-devel@gnu.org, and we will send you the necessary form together with the instructions to fill and email it, in order to start this legal paperwork.