unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: utomei@tiscali.it, 61988@debbugs.gnu.org
Subject: bug#61988: error compiling emacs
Date: Mon, 06 Mar 2023 17:38:25 +0200	[thread overview]
Message-ID: <83v8jd7uvi.fsf@gnu.org> (raw)
In-Reply-To: <871qm2q9lh.fsf@yahoo.com> (message from Po Lu on Mon, 06 Mar 2023 21:43:06 +0800)

reopen 61988
thanks

> From: Po Lu <luangruo@yahoo.com>
> Cc: utomei@tiscali.it,  61988-done@debbugs.gnu.org
> Date: Mon, 06 Mar 2023 21:43:06 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Po Lu <luangruo@yahoo.com>
> >> Cc: 61988@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
> >> Date: Mon, 06 Mar 2023 18:35:05 +0800
> >> 
> >> >> -      WEBP_MODULE="libwebpdemux >= $WEBP_REQUIRED"
> >> >> +      WEBP_MODULE="libwebpdemux >= $WEBP_REQUIRED libwebpdecoder >= $WEBP_REQUIRED"
> >> >>           EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE])
> >> >>         AC_SUBST([WEBP_CFLAGS])
> >> >>
> >> >> Everyone else, make sure to link to *EVERYTHING* that you depend on, not
> >> >> just one library that happens to link to everything you depend on.
> >> >> Thanks.
> >> 
> >> Thanks.  Eli, is this safe for Emacs 29?
> >
> > Yes, thanks.
> 
> Thanks, I installed the patch and am closing this bug.

Sorry, I wasn't paying close attention, and though that you are adding
libwebpdemux.  With linwebpdecoder, the test fails on my system, since
libwebpdecoder is not installed and neither is its pkg-config file.
And is not needed: we don't use any API from that library, AFAICT.

So I've reverted that change for now, and I'm reopening the bug.

I'd like to know why requiring libwebpdecoder is essential for the
build to work on the OP's system.  It isn't on mine, and if you look
at init_webp_functions, you will see that on Windows we load functions
only from libwebp and libwebpdemux.  Why is the third library needed?





  reply	other threads:[~2023-03-06 15:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-05 11:23 bug#61988: error compiling emacs Ugo Tomei
2023-03-05 19:41 ` Eli Zaretskii
2023-03-06  9:10   ` Ugo Tomei
2023-03-06  0:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-06  9:38   ` Ugo Tomei
2023-03-06 10:35     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-06 12:08       ` Eli Zaretskii
2023-03-06 13:43         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-06 15:38           ` Eli Zaretskii [this message]
2023-03-07  0:34             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07  3:38               ` Eli Zaretskii
2023-03-07  5:03                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 13:00                   ` Eli Zaretskii
2023-03-07 13:36                     ` bug#61988: R: " Ugo Tomei
2023-03-07 14:11                       ` Eli Zaretskii
2023-03-07 14:34                         ` bug#61988: R: " Ugo Tomei
2023-03-07 15:27                           ` Eli Zaretskii
2023-03-07 16:21                             ` Eli Zaretskii
2023-03-07 16:44                         ` bug#61988: R: " Ugo Tomei
2023-03-07 16:59                           ` Eli Zaretskii
2023-03-08  0:09                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-08  8:32                               ` Ugo Tomei
2023-03-08  9:02                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-08  9:44                                   ` Ugo Tomei
2023-03-08 10:42                                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-08 12:26                                       ` Ugo Tomei
2023-03-08 12:55                                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-08 14:24                                           ` Eli Zaretskii
2023-09-06  0:01                                             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v8jd7uvi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61988@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=utomei@tiscali.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).