From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61988: error compiling emacs Date: Mon, 06 Mar 2023 17:38:25 +0200 Message-ID: <83v8jd7uvi.fsf@gnu.org> References: <874jqyspc7.fsf@yahoo.com> <6db27b89-699b-f956-4205-6cd8144f6dea@tiscali.it> <87v8jeqiau.fsf@yahoo.com> <83bkl684lp.fsf@gnu.org> <871qm2q9lh.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32864"; mail-complaints-to="usenet@ciao.gmane.io" Cc: utomei@tiscali.it, 61988@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 06 16:53:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZD98-0008J8-Fw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Mar 2023 16:53:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZCvY-0002eZ-7H; Mon, 06 Mar 2023 10:39:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCvW-0002VT-Q2 for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2023 10:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZCvW-00035W-Gd for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2023 10:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZCvW-0001Ls-73 for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2023 10:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Mar 2023 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61988 X-GNU-PR-Package: emacs Original-Received: via spool by 61988-submit@debbugs.gnu.org id=B61988.16781171295167 (code B ref 61988); Mon, 06 Mar 2023 15:39:02 +0000 Original-Received: (at 61988) by debbugs.gnu.org; 6 Mar 2023 15:38:49 +0000 Original-Received: from localhost ([127.0.0.1]:43354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZCvI-0001LG-M2 for submit@debbugs.gnu.org; Mon, 06 Mar 2023 10:38:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZCvG-0001Ky-RD; Mon, 06 Mar 2023 10:38:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCv8-00031v-Ma; Mon, 06 Mar 2023 10:38:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dGOmHdElDzpRp7E33Nv4n2u2j+DvuudUyde7BCwDjt8=; b=OyOfsa7xBm8I EFW3Yk1elstxvBHs3xl+xw3SsYrN/XQliUu7TnEunlUdABWDP20snxcHlprCI8ihgv/Hl9ekNb0af y2wzsKcwR2d4inVrp+omwSvSGYizusJgMT+WplewVLk4jmJ2vjPvtqjWIbh0LwUSJ3A0ugJ8m00zt E2MkXGEU5X3RwXPUw3GZQnf9pyul3GcHvCPHHONtICaO1tACmPWu+p8Njbny4edkzFFo35hWOIjnf bi712oaiBDLVEWm4VE4aaOQKhnAa/P3OAeEN9gn5TXCkYcPQ51d0yGKW/VcmOlFaFZi06NU6t66j1 1ybRBICSjxSZQ+D/zXpeOg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCv2-0001CZ-ON; Mon, 06 Mar 2023 10:38:38 -0500 In-Reply-To: <871qm2q9lh.fsf@yahoo.com> (message from Po Lu on Mon, 06 Mar 2023 21:43:06 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257402 Archived-At: reopen 61988 thanks > From: Po Lu > Cc: utomei@tiscali.it, 61988-done@debbugs.gnu.org > Date: Mon, 06 Mar 2023 21:43:06 +0800 > > Eli Zaretskii writes: > > >> From: Po Lu > >> Cc: 61988@debbugs.gnu.org, Eli Zaretskii > >> Date: Mon, 06 Mar 2023 18:35:05 +0800 > >> > >> >> - WEBP_MODULE="libwebpdemux >= $WEBP_REQUIRED" > >> >> + WEBP_MODULE="libwebpdemux >= $WEBP_REQUIRED libwebpdecoder >= $WEBP_REQUIRED" > >> >> EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE]) > >> >> AC_SUBST([WEBP_CFLAGS]) > >> >> > >> >> Everyone else, make sure to link to *EVERYTHING* that you depend on, not > >> >> just one library that happens to link to everything you depend on. > >> >> Thanks. > >> > >> Thanks. Eli, is this safe for Emacs 29? > > > > Yes, thanks. > > Thanks, I installed the patch and am closing this bug. Sorry, I wasn't paying close attention, and though that you are adding libwebpdemux. With linwebpdecoder, the test fails on my system, since libwebpdecoder is not installed and neither is its pkg-config file. And is not needed: we don't use any API from that library, AFAICT. So I've reverted that change for now, and I'm reopening the bug. I'd like to know why requiring libwebpdecoder is essential for the build to work on the OP's system. It isn't on mine, and if you look at init_webp_functions, you will see that on Windows we load functions only from libwebp and libwebpdemux. Why is the third library needed?