unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org
Subject: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work.
Date: Sun, 30 Oct 2016 18:21:19 +0200	[thread overview]
Message-ID: <83twbtq03k.fsf@gnu.org> (raw)
In-Reply-To: <87funefz1i.fsf@topbug.net> (message from Hong Xu on Sat, 29 Oct 2016 17:42:01 -0700)

> From: Hong Xu <hong@topbug.net>
> Date: Sat, 29 Oct 2016 17:42:01 -0700
> Cc: 23436@debbugs.gnu.org
> 
> The attachment is a draft of my proposed doc change. Feel free to adjust
> the contents and the language.

Thanks, see a few comments below.

> diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi
> index aca29910b7d3..8f31fa168c23 100644
> --- a/doc/emacs/maintaining.texi
> +++ b/doc/emacs/maintaining.texi

This should go to the ELisp manual, not the Emacs User manual.

> +@defun vc-responsible-backend file
> +This function can be used to determine the responsible VC backend of
> +the given file path @var{file}.

GNU coding standards frown on using "path" for anything that isn't a
PATH-style list of directories.  We use "file name" instead, but in
this case you don't need even that: just say "the given @var{file}".

>                                  For example, if @code{emacs.c} is a

emacs.c is a file, so it should have the @file markup, not @code.

> +file tracked by git, @code{(vc-responsible-backend "emacs.c")} returns
> +@code{"Git"}.
   ^^^^^^^^^^^^
You want @samp{Git} here, without the quotes.  The quotes might
mislead someone into thinking the result is a string.

Last, but not least: documentation changes need ChangeLog-style commit
log messages as well (just use "C-x 4 a" to get a preformatted
skeleton from which you could start).





  reply	other threads:[~2016-10-30 16:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 21:32 bug#23436: [PATCH] Use the true name of a file to determine responsible vc Hong Xu
2016-10-19 19:19 ` Hong Xu
2016-10-19 19:33   ` bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work Hong Xu
2016-10-19 23:37     ` Dmitry Gutov
2016-10-19 23:49       ` Hong Xu
2016-10-19 23:58         ` Dmitry Gutov
2016-10-20  0:16           ` Hong Xu
2016-10-20  6:58             ` Eli Zaretskii
2016-10-20  7:21               ` Hong Xu
2016-10-20  8:23                 ` Eli Zaretskii
2016-10-20  8:50                   ` Dmitry Gutov
2016-10-20  9:46                   ` Andreas Schwab
2016-10-20 10:02                     ` Eli Zaretskii
2016-10-20 10:58                       ` Eli Zaretskii
2016-10-20  9:47             ` Dmitry Gutov
2016-10-20 16:39               ` Hong Xu
2016-10-20 22:34                 ` Dmitry Gutov
2016-10-20 23:04                   ` Hong Xu
2016-10-24 23:41                     ` Dmitry Gutov
2016-10-25 19:05                       ` Hong Xu
2016-10-25 23:12                         ` Dmitry Gutov
2016-10-30  0:42                           ` Hong Xu
2016-10-30 16:21                             ` Eli Zaretskii [this message]
2016-10-30 22:50                               ` Hong Xu
2016-10-31 15:43                                 ` Eli Zaretskii
2016-10-31 19:38                                   ` Hong Xu
2016-11-01 18:47                                     ` Eli Zaretskii
2016-11-04  7:46                                       ` Hong Xu
2016-11-04 10:08                                         ` Eli Zaretskii
2016-10-31 11:34                             ` Dmitry Gutov
2016-10-31 19:24                               ` Hong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83twbtq03k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23436@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=hong@topbug.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).