From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org
Subject: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work.
Date: Thu, 20 Oct 2016 09:58:13 +0300 [thread overview]
Message-ID: <837f93v75m.fsf@gnu.org> (raw)
In-Reply-To: <b5e6001a-afc5-08c7-0080-4b2c06f02964@topbug.net> (message from Hong Xu on Wed, 19 Oct 2016 17:16:58 -0700)
> From: Hong Xu <hong@topbug.net>
> Date: Wed, 19 Oct 2016 17:16:58 -0700
>
> >>>> + (dolist (file-path (list file (file-truename file)))
> >>>
> >>> Why not just use the true name?
> >>
> >> Because sometimes we track symlinks specifically. The symlink files may
> >> link to a file in a different repo, for example a git submodule.
> >
> > I'm not sure I understand. Please outline a problem scenario.
>
> mkdir my-repo && cd my-repo
> hg init
> git clone git://git.savannah.gnu.org/emacs.git
> ln -s emacs/README README_emacs
> hg add README_emacs
>
> README_emacs is tracked in the repo "my-repo" but README is tracked in
> the emacs repo. If true name is directly used, we would fail to obtain
> the correct responsible backend.
What is the correct backend in this case? You seem to assume it's the
one that maintains the symlink, but why is that assumption true?
The backend is determined for certain operations. Did you make sure
all of them will indeed want the backend of my-repo and not the other
one.
And what is the semantics of such a situation, anyway?
next prev parent reply other threads:[~2016-10-20 6:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 21:32 bug#23436: [PATCH] Use the true name of a file to determine responsible vc Hong Xu
2016-10-19 19:19 ` Hong Xu
2016-10-19 19:33 ` bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work Hong Xu
2016-10-19 23:37 ` Dmitry Gutov
2016-10-19 23:49 ` Hong Xu
2016-10-19 23:58 ` Dmitry Gutov
2016-10-20 0:16 ` Hong Xu
2016-10-20 6:58 ` Eli Zaretskii [this message]
2016-10-20 7:21 ` Hong Xu
2016-10-20 8:23 ` Eli Zaretskii
2016-10-20 8:50 ` Dmitry Gutov
2016-10-20 9:46 ` Andreas Schwab
2016-10-20 10:02 ` Eli Zaretskii
2016-10-20 10:58 ` Eli Zaretskii
2016-10-20 9:47 ` Dmitry Gutov
2016-10-20 16:39 ` Hong Xu
2016-10-20 22:34 ` Dmitry Gutov
2016-10-20 23:04 ` Hong Xu
2016-10-24 23:41 ` Dmitry Gutov
2016-10-25 19:05 ` Hong Xu
2016-10-25 23:12 ` Dmitry Gutov
2016-10-30 0:42 ` Hong Xu
2016-10-30 16:21 ` Eli Zaretskii
2016-10-30 22:50 ` Hong Xu
2016-10-31 15:43 ` Eli Zaretskii
2016-10-31 19:38 ` Hong Xu
2016-11-01 18:47 ` Eli Zaretskii
2016-11-04 7:46 ` Hong Xu
2016-11-04 10:08 ` Eli Zaretskii
2016-10-31 11:34 ` Dmitry Gutov
2016-10-31 19:24 ` Hong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837f93v75m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23436@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=hong@topbug.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).