unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#25168: 25.1; variable-pitch face misbehaves
@ 2016-12-11 10:47 Eli Barzilay
  2016-12-11 15:35 ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Barzilay @ 2016-12-11 10:47 UTC (permalink / raw)
  To: 25168

I'm using Emacs with a rather large default font.  One thing that
doesn't work well on Windows is variable-pitch face: it is much
smaller than my usual font.  Another way to see this without
customizing the font:

* run `info`

* use `text-scale-adjust` to make the font larger

* notice that variable-pitch headers stay at the same size

I looked at the definition of the face and followed the linked
discussion: indeed, when I try to reset the face to the same (using
just :family "Sans Serif") I get a bold-italic version of Arial, and
the best I could get was a larger version of plain Arial (using a
similar string, with a larger number instead of a "*") that is
similarly unaffected by size settings.

-- 
                   ((x=>x(x))(x=>x(x)))                  Eli Barzilay:
                   http://barzilay.org/                  Maze is Life!





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25168: 25.1; variable-pitch face misbehaves
  2016-12-11 10:47 bug#25168: 25.1; variable-pitch face misbehaves Eli Barzilay
@ 2016-12-11 15:35 ` Eli Zaretskii
  2021-02-06 11:42   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2016-12-11 15:35 UTC (permalink / raw)
  To: Eli Barzilay; +Cc: 25168

> From: Eli Barzilay <eli@barzilay.org>
> Date: Sun, 11 Dec 2016 05:47:25 -0500
> 
> I'm using Emacs with a rather large default font.  One thing that
> doesn't work well on Windows is variable-pitch face: it is much
> smaller than my usual font.  Another way to see this without
> customizing the font:
> 
> * run `info`
> 
> * use `text-scale-adjust` to make the font larger
> 
> * notice that variable-pitch headers stay at the same size

Is this really related to variable-pitch fonts, or is this related to
the fact that the face is defined with a height attribute relative to
the default face?

AFAIR, text-scale-adjust only affects the basic faces, not any
arbitrary face defined by modes.  But maybe I misremember.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25168: 25.1; variable-pitch face misbehaves
  2016-12-11 15:35 ` Eli Zaretskii
@ 2021-02-06 11:42   ` Lars Ingebrigtsen
  2021-02-06 12:22     ` Eli Barzilay
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-02-06 11:42 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Eli Barzilay, 25168

Eli Zaretskii <eliz@gnu.org> writes:

> Is this really related to variable-pitch fonts, or is this related to
> the fact that the face is defined with a height attribute relative to
> the default face?
>
> AFAIR, text-scale-adjust only affects the basic faces, not any
> arbitrary face defined by modes.  But maybe I misremember.

Yup --

----
Adjust the height of the default face by INC.
----

So it's not supposed to do anything for other faces, and I guess this is
working as documented.  So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25168: 25.1; variable-pitch face misbehaves
  2021-02-06 11:42   ` Lars Ingebrigtsen
@ 2021-02-06 12:22     ` Eli Barzilay
  2021-02-06 12:33       ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Barzilay @ 2021-02-06 12:22 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 25168

It would be nice to clarify that in the `text-scale-adjust` docstring.
To be more specific, it currently repeats:

    the default face height

many times, and this can be interpreted as "the default (face height)"
or "the (default face) height".  Worse, for people who don't know that
there's an actual face called default, "Adjust the height of the default
face" is just as confusing.

On Sat, Feb 6, 2021 at 6:42 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Is this really related to variable-pitch fonts, or is this related to
> > the fact that the face is defined with a height attribute relative to
> > the default face?
> >
> > AFAIR, text-scale-adjust only affects the basic faces, not any
> > arbitrary face defined by modes.  But maybe I misremember.
>
> Yup --
>
> ----
> Adjust the height of the default face by INC.
> ----
>
> So it's not supposed to do anything for other faces, and I guess this is
> working as documented.  So I'm closing this bug report.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no



-- 
                   ((x=>x(x))(x=>x(x)))                  Eli Barzilay:
                   http://barzilay.org/                  Maze is Life!





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25168: 25.1; variable-pitch face misbehaves
  2021-02-06 12:22     ` Eli Barzilay
@ 2021-02-06 12:33       ` Eli Zaretskii
  2021-02-06 18:50         ` Eli Barzilay
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2021-02-06 12:33 UTC (permalink / raw)
  To: Eli Barzilay; +Cc: larsi, 25168

> From: Eli Barzilay <eli@barzilay.org>
> Date: Sat, 6 Feb 2021 07:22:41 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, 25168@debbugs.gnu.org
> 
> It would be nice to clarify that in the `text-scale-adjust` docstring.
> To be more specific, it currently repeats:
> 
>     the default face height
> 
> many times, and this can be interpreted as "the default (face height)"
> or "the (default face) height".  Worse, for people who don't know that
> there's an actual face called default, "Adjust the height of the default
> face" is just as confusing.

I made it say "adjust the height of the default face" because I think
it should be clear (or at least more clear than the original wording).





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#25168: 25.1; variable-pitch face misbehaves
  2021-02-06 12:33       ` Eli Zaretskii
@ 2021-02-06 18:50         ` Eli Barzilay
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Barzilay @ 2021-02-06 18:50 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Lars Ingebrigtsen, 25168

That's much better, thanks!  -- It would be nice to add some comment
somewhere that not all faces inherit from it (but I can't figure out a
short way of saying that).

On Sat, Feb 6, 2021 at 7:33 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Eli Barzilay <eli@barzilay.org>
> > Date: Sat, 6 Feb 2021 07:22:41 -0500
> > Cc: Eli Zaretskii <eliz@gnu.org>, 25168@debbugs.gnu.org
> >
> > It would be nice to clarify that in the `text-scale-adjust` docstring.
> > To be more specific, it currently repeats:
> >
> >     the default face height
> >
> > many times, and this can be interpreted as "the default (face height)"
> > or "the (default face) height".  Worse, for people who don't know that
> > there's an actual face called default, "Adjust the height of the default
> > face" is just as confusing.
>
> I made it say "adjust the height of the default face" because I think
> it should be clear (or at least more clear than the original wording).



-- 
                   ((x=>x(x))(x=>x(x)))                  Eli Barzilay:
                   http://barzilay.org/                  Maze is Life!





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-06 18:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-11 10:47 bug#25168: 25.1; variable-pitch face misbehaves Eli Barzilay
2016-12-11 15:35 ` Eli Zaretskii
2021-02-06 11:42   ` Lars Ingebrigtsen
2021-02-06 12:22     ` Eli Barzilay
2021-02-06 12:33       ` Eli Zaretskii
2021-02-06 18:50         ` Eli Barzilay

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).