From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 45412@debbugs.gnu.org, larsi@gnus.org, jidanni@jidanni.org,
juri@linkov.net
Subject: bug#45412: File ... is large (... MiB), really open? (y)es or (n)o or (l)iterally
Date: Thu, 06 May 2021 11:30:57 +0300 [thread overview]
Message-ID: <83tunge01q.fsf@gnu.org> (raw)
In-Reply-To: <m1lf8sydyn.fsf@yahoo.es> (message from Daniel Martín on Thu, 06 May 2021 01:10:08 +0200)
> From: Daniel Martín <mardani29@yahoo.es>
> Cc: Eli Zaretskii <eliz@gnu.org>, 45412@debbugs.gnu.org,
> jidanni@jidanni.org, juri@linkov.net
> Date: Thu, 06 May 2021 01:10:08 +0200
>
> I think I've applied all code review suggestions (patches attached).
Thanks, there are still a couple of nits left:
> * lisp/emacs-lisp/rmc.el (read-multiple-choice): Add a new argument to
> override the default help description in `read-multiple-choice'. Use
> the `help-char' variable instead of ?\C-h. Also support the `edit'
> action from `query-replace-map', so that help links can be visited by
> entering a recursive edit.
In commit log messages and in NEWS we nowadays prefer quoting 'like
this', not `like this'.
> +shortened). DESCRIPTION is an optional longer explanation for
> +the entry that will be displayed in a help buffer if the user
> +requests more help. This help description has a fixed format in
> +columns, but, for greater flexibility, instead of passing a
> +DESCRIPTION, the user can use the optional argument HELP-STRING.
> +This argument is a string that contains the text with the
> +complete description of all choices. `read-multiple-choice' will
> +display that description in a help buffer if the user requests
> +it.
You say "user" here several times, but I think you mean the Lisp
program that calls this function, not the Emacs user.
> + (substitute-command-keys
> + "Recursive edit. Resume with \\[exit-recursive-edit]"))
I think "resume" is too vague here to be useful. Suggest to reword:
Recursive edit; type \\[exit-recursive-edit] to return to help screen.
next prev parent reply other threads:[~2021-05-06 8:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 14:44 bug#45412: File ... is large (... MiB), really open? (y)es or (n)o or (l)iterally 積丹尼 Dan Jacobson
2020-12-25 1:00 ` Unknown
2020-12-25 1:29 ` 積丹尼 Dan Jacobson
2020-12-25 5:52 ` Lars Ingebrigtsen
2020-12-25 9:32 ` Juri Linkov
2021-04-10 22:32 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-10 22:52 ` Juri Linkov
2021-04-11 7:03 ` Eli Zaretskii
2021-04-12 8:06 ` Lars Ingebrigtsen
2021-04-16 23:50 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-17 11:44 ` Lars Ingebrigtsen
2021-04-21 22:12 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-22 10:04 ` Eli Zaretskii
2021-04-25 19:14 ` Lars Ingebrigtsen
2021-04-25 21:23 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 2:28 ` Eli Zaretskii
2021-04-27 1:08 ` Lars Ingebrigtsen
2021-05-05 23:10 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 8:28 ` Lars Ingebrigtsen
2021-05-06 8:30 ` Eli Zaretskii [this message]
2021-05-07 14:11 ` Eli Zaretskii
2021-05-08 11:37 ` Lars Ingebrigtsen
2021-05-08 12:22 ` Eli Zaretskii
2021-05-09 9:57 ` Lars Ingebrigtsen
2021-05-09 10:04 ` Eli Zaretskii
2021-04-22 22:09 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tunge01q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45412@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).