From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45412: File ... is large (... MiB), really open? (y)es or (n)o or (l)iterally Date: Thu, 06 May 2021 11:30:57 +0300 Message-ID: <83tunge01q.fsf@gnu.org> References: <87k0t72rhd.5.fsf@jidanni.org> <8735zuig9m.fsf@gnus.org> <87wnx62rpe.fsf@mail.linkov.net> <877dl80vwk.fsf@gnus.org> <87mttxqgnv.fsf@gnus.org> <83fsziprdf.fsf@gnu.org> <877dkqjhwd.fsf@gnus.org> <87zgxk1qlm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19912"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45412@debbugs.gnu.org, larsi@gnus.org, jidanni@jidanni.org, juri@linkov.net To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 10:32:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZQi-00052z-PF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 10:32:20 +0200 Original-Received: from localhost ([::1]:36702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZQh-00007B-Oj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 04:32:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leZQQ-00006w-Bn for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53715) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leZQQ-0006nw-3j for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leZQQ-0004R7-0i for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 08:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 45412-submit@debbugs.gnu.org id=B45412.162028987714932 (code B ref 45412); Thu, 06 May 2021 08:32:01 +0000 Original-Received: (at 45412) by debbugs.gnu.org; 6 May 2021 08:31:17 +0000 Original-Received: from localhost ([127.0.0.1]:37028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZPh-0003sT-5s for submit@debbugs.gnu.org; Thu, 06 May 2021 04:31:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZPf-0003m2-0A for 45412@debbugs.gnu.org; Thu, 06 May 2021 04:31:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50252) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZPZ-0006FT-0S; Thu, 06 May 2021 04:31:09 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4311 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leZPY-0003ki-KB; Thu, 06 May 2021 04:31:08 -0400 In-Reply-To: (message from Daniel =?UTF-8?Q?Mart=C3=ADn?= on Thu, 06 May 2021 01:10:08 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205771 Archived-At: > From: Daniel Martín > Cc: Eli Zaretskii , 45412@debbugs.gnu.org, > jidanni@jidanni.org, juri@linkov.net > Date: Thu, 06 May 2021 01:10:08 +0200 > > I think I've applied all code review suggestions (patches attached). Thanks, there are still a couple of nits left: > * lisp/emacs-lisp/rmc.el (read-multiple-choice): Add a new argument to > override the default help description in `read-multiple-choice'. Use > the `help-char' variable instead of ?\C-h. Also support the `edit' > action from `query-replace-map', so that help links can be visited by > entering a recursive edit. In commit log messages and in NEWS we nowadays prefer quoting 'like this', not `like this'. > +shortened). DESCRIPTION is an optional longer explanation for > +the entry that will be displayed in a help buffer if the user > +requests more help. This help description has a fixed format in > +columns, but, for greater flexibility, instead of passing a > +DESCRIPTION, the user can use the optional argument HELP-STRING. > +This argument is a string that contains the text with the > +complete description of all choices. `read-multiple-choice' will > +display that description in a help buffer if the user requests > +it. You say "user" here several times, but I think you mean the Lisp program that calls this function, not the Emacs user. > + (substitute-command-keys > + "Recursive edit. Resume with \\[exit-recursive-edit]")) I think "resume" is too vague here to be useful. Suggest to reword: Recursive edit; type \\[exit-recursive-edit] to return to help screen.