From: Eli Zaretskii <eliz@gnu.org>
To: kevin.legouguec@gmail.com
Cc: gregory@heytings.org, 60841@debbugs.gnu.org, juri@linkov.net
Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted
Date: Sun, 29 Jan 2023 22:32:40 +0200 [thread overview]
Message-ID: <83tu095bfb.fsf@gnu.org> (raw)
In-Reply-To: <83zga15e5p.fsf@gnu.org> (message from Eli Zaretskii on Sun, 29 Jan 2023 21:33:38 +0200)
> Cc: gregory@heytings.org, 60841@debbugs.gnu.org, kevin.legouguec@gmail.com
> Date: Sun, 29 Jan 2023 21:33:38 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> I think face-differs-from-default-p should look like this:
>
> (defun face-differs-from-default-p (face &optional frame)
> "Return non-nil if FACE displays differently from the default face.
> If the optional argument FRAME is given, report on face FACE in that frame.
> If FRAME is t, report on the defaults for face FACE (for new frames).
> If FRAME is omitted or nil, use the selected frame."
> (let ((attrs
> (delq :inherit (delq :extend (mapcar 'car face-attribute-name-alist))))
> (differs nil))
> (while (and attrs (not differs))
> (let* ((attr (pop attrs))
> (attr-val (face-attribute face attr frame t)))
> (when (and
> (not (eq attr-val 'unspecified))
> (not (equal attr-val (face-attribute 'default attr frame)))
> (display-supports-face-attributes-p (list attr attr-val)
> frame))
> (setq differs attr))))
> differs))
Actually, I take this back: the 'equal' part is already done by
display-supports-face-attributes-p.
The problem with :stipple is that we don't allow nil as the value of
:stipple. If you evaluate
(setq list-matching-lines-prefix-face 'default)
(face-differs-from-default-p list-matching-lines-prefix-face)
then look in *Messages*, you will see:
Invalid face attribute :stipple nil
So we need to treat :stipple specially, or maybe fix merge_face_ref to
allow the nil value.
prev parent reply other threads:[~2023-01-29 20:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 23:38 bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Kévin Le Gouguec
2023-01-16 12:47 ` Eli Zaretskii
2023-01-16 21:58 ` Kévin Le Gouguec
2023-01-16 22:28 ` Gregory Heytings
2023-01-17 7:53 ` Kévin Le Gouguec
2023-01-17 8:26 ` Gregory Heytings
2023-01-17 22:03 ` Kévin Le Gouguec
2023-01-18 13:12 ` Eli Zaretskii
2023-01-18 22:16 ` Kévin Le Gouguec
2023-01-21 8:08 ` Eli Zaretskii
2023-01-22 22:45 ` Kévin Le Gouguec
2023-01-23 13:01 ` Eli Zaretskii
2023-01-23 22:29 ` Kévin Le Gouguec
2023-01-24 13:23 ` Eli Zaretskii
2023-01-28 17:45 ` Kévin Le Gouguec
2023-01-28 18:07 ` Eli Zaretskii
2023-01-29 14:54 ` Kévin Le Gouguec
2023-01-29 15:40 ` Eli Zaretskii
2023-01-29 22:57 ` Kévin Le Gouguec
2023-01-30 12:41 ` Eli Zaretskii
2023-01-30 22:38 ` Kévin Le Gouguec
2023-02-02 10:43 ` Eli Zaretskii
2023-02-02 21:15 ` Kévin Le Gouguec
2023-01-29 17:55 ` Juri Linkov
2023-01-29 19:09 ` Eli Zaretskii
2023-01-29 19:33 ` Eli Zaretskii
2023-01-29 20:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tu095bfb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60841@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=juri@linkov.net \
--cc=kevin.legouguec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).