From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Sun, 29 Jan 2023 22:32:40 +0200 Message-ID: <83tu095bfb.fsf@gnu.org> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> <833581jtff.fsf@gnu.org> <87lelsga1f.fsf@gmail.com> <83r0vkgj7l.fsf@gnu.org> <87h6wawo2k.fsf@gmail.com> <831qnea5ye.fsf@gnu.org> <87357t2xyh.fsf@gmail.com> <86ilgpb3lv.fsf@mail.linkov.net> <831qnd6tup.fsf@gnu.org> <83zga15e5p.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8648"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60841@debbugs.gnu.org, juri@linkov.net To: kevin.legouguec@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 21:33:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMEMe-00022U-E7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 21:33:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMEMK-0000qa-Fx; Sun, 29 Jan 2023 15:33:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMEMJ-0000qK-9N for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 15:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMEMI-0000Dx-SH for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 15:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMEMI-0001MN-Bv for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 15:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.16750243795218 (code B ref 60841); Sun, 29 Jan 2023 20:33:02 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 29 Jan 2023 20:32:59 +0000 Original-Received: from localhost ([127.0.0.1]:45457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMEME-0001M5-Hv for submit@debbugs.gnu.org; Sun, 29 Jan 2023 15:32:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMEMC-0001Lq-R2 for 60841@debbugs.gnu.org; Sun, 29 Jan 2023 15:32:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMEM7-0000DW-10; Sun, 29 Jan 2023 15:32:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S66l9SMXp2ljNFdkAWLgaux2gLI1yopJnr2SGihhtTU=; b=KxwLFMdxKBJv Kw0Dx1XxrNAh9UMbx8F5WI8HmUcblOcleTkpz8co3dmfo/gLdBhphfYYa2qEbzPx3iIF+2g82ba8S firo4Uvu+1JNYeCrw9Z8vAmwtxzzxCtAMIxr4aQDAQSO2Ebf27C/+lVUkoVtTW17H3eNB6/5RosMS PLf5stRay9ZZZ5SfsRb9rt8fFt0G2DgnSQvLldE449L1kMVtdSAtAiBgkl75cEzbWgzk0nRbTY2iZ L8J3ZC7RhfPK1F6U/RXN3713AvhDJ8EvocGw+3ORzfAPlASAGUzf2rMdtjZhplGBE+75190Yc2RCi 8yvNTTi+CB6kUUJMKNNc3A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMEM5-0002wc-MS; Sun, 29 Jan 2023 15:32:50 -0500 In-Reply-To: <83zga15e5p.fsf@gnu.org> (message from Eli Zaretskii on Sun, 29 Jan 2023 21:33:38 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254381 Archived-At: > Cc: gregory@heytings.org, 60841@debbugs.gnu.org, kevin.legouguec@gmail.com > Date: Sun, 29 Jan 2023 21:33:38 +0200 > From: Eli Zaretskii > > I think face-differs-from-default-p should look like this: > > (defun face-differs-from-default-p (face &optional frame) > "Return non-nil if FACE displays differently from the default face. > If the optional argument FRAME is given, report on face FACE in that frame. > If FRAME is t, report on the defaults for face FACE (for new frames). > If FRAME is omitted or nil, use the selected frame." > (let ((attrs > (delq :inherit (delq :extend (mapcar 'car face-attribute-name-alist)))) > (differs nil)) > (while (and attrs (not differs)) > (let* ((attr (pop attrs)) > (attr-val (face-attribute face attr frame t))) > (when (and > (not (eq attr-val 'unspecified)) > (not (equal attr-val (face-attribute 'default attr frame))) > (display-supports-face-attributes-p (list attr attr-val) > frame)) > (setq differs attr)))) > differs)) Actually, I take this back: the 'equal' part is already done by display-supports-face-attributes-p. The problem with :stipple is that we don't allow nil as the value of :stipple. If you evaluate (setq list-matching-lines-prefix-face 'default) (face-differs-from-default-p list-matching-lines-prefix-face) then look in *Messages*, you will see: Invalid face attribute :stipple nil So we need to treat :stipple specially, or maybe fix merge_face_ref to allow the nil value.