From: Eli Zaretskii <eliz@gnu.org>
To: skykanin <skykanin@proton.me>, "João Távora" <joaotavora@gmail.com>
Cc: 61312@debbugs.gnu.org
Subject: bug#61312: Patch for eglot: scala LSP binary name
Date: Mon, 06 Feb 2023 17:46:23 +0200 [thread overview]
Message-ID: <83ttzypzjk.fsf@gnu.org> (raw)
In-Reply-To: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> (bug-gnu-emacs@gnu.org)
> Date: Sun, 05 Feb 2023 21:15:48 +0000
> From: skykanin via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> It seems that eglot expects the scala metals LSP server binary to be named `metals-emacs` instead of `metals`. The included patch fixes this behaviour. At least in the nix package manager the `metals` binary is simply call 'metals'. However if other package managers distribute an alias for the binary as 'metals-emacs' as well we could instead do something like:
> ```
> (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))
> ```
Looking at this site:
https://github.com/rossabaker/lsp-scala
I see this:
(defcustom lsp-scala-server-command "metals-emacs"
"The command to launch the Scala language server."
:group 'lsp-scala
:type 'file)
So maybe we do need to support both names.
João, WDYT?
next prev parent reply other threads:[~2023-02-06 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 21:15 bug#61312: Patch for eglot: scala LSP binary name skykanin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-06 15:46 ` Eli Zaretskii [this message]
2023-02-06 18:45 ` João Távora
2023-02-09 10:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttzypzjk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61312@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=skykanin@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).