From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61312: Patch for eglot: scala LSP binary name Date: Mon, 06 Feb 2023 17:46:23 +0200 Message-ID: <83ttzypzjk.fsf@gnu.org> References: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32524"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61312@debbugs.gnu.org To: skykanin , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 06 16:47:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP3id-0008Dw-L4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Feb 2023 16:47:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP3iK-0003FR-SU; Mon, 06 Feb 2023 10:47:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP3hu-0003BP-Pc for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 10:47:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP3hu-0000wl-DF for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 10:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pP3hu-0003qn-3W for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 10:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61312 X-GNU-PR-Package: emacs Original-Received: via spool by 61312-submit@debbugs.gnu.org id=B61312.167569838314742 (code B ref 61312); Mon, 06 Feb 2023 15:47:02 +0000 Original-Received: (at 61312) by debbugs.gnu.org; 6 Feb 2023 15:46:23 +0000 Original-Received: from localhost ([127.0.0.1]:49649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP3hG-0003ph-Ln for submit@debbugs.gnu.org; Mon, 06 Feb 2023 10:46:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP3hE-0003pU-1R for 61312@debbugs.gnu.org; Mon, 06 Feb 2023 10:46:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP3h5-0000iD-Et; Mon, 06 Feb 2023 10:46:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=q69seeDp9DvQaxTNiQ9MNlTFYa4j8GFyVY2D5vl23Y8=; b=TLuwX9R6lvclG6PETe2+ 746g9acWPE08Omym5HoPPDWCUFEmghhdWf3Dc4fREqAChW3/3zlQLcmg52Tl+J6wsIhs1pRbWguhl Ixhuzs9MqT1SajFuXhiPf9x/qMzSLkrWFA/dnsO/GZCnfQyw1aOoHfnOU1mJr79pAcvXAZxPpzSne GbV5enWzhAB3qooilKZgzQ4iCyJ+7hVB760x4ujjIouGj4cNoa0/bPZg5PuWJ8JVwwEQ/3M6XSpdS vAjU8zgr121Pn91eq75vKMczi6YqEv+XQmqUxv0z1HXdGsMM2FXY0BWJk19smPIddvNHN0HRfJ/ga KJyY8PRAhm5Xgw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP3h4-0007dt-Ua; Mon, 06 Feb 2023 10:46:11 -0500 In-Reply-To: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254969 Archived-At: > Date: Sun, 05 Feb 2023 21:15:48 +0000 > From: skykanin via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > It seems that eglot expects the scala metals LSP server binary to be named `metals-emacs` instead of `metals`. The included patch fixes this behaviour. At least in the nix package manager the `metals` binary is simply call 'metals'. However if other package managers distribute an alias for the binary as 'metals-emacs' as well we could instead do something like: > ``` > (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs")) > ``` Looking at this site: https://github.com/rossabaker/lsp-scala I see this: (defcustom lsp-scala-server-command "metals-emacs" "The command to launch the Scala language server." :group 'lsp-scala :type 'file) So maybe we do need to support both names. João, WDYT?