unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 8035@debbugs.gnu.org, slpnabble@blackberry-hill.com
Subject: bug#8035: Processing of .. in a file path after going thru symlink
Date: Thu, 26 Aug 2021 19:44:11 +0300	[thread overview]
Message-ID: <83sfywrw9w.fsf@gnu.org> (raw)
In-Reply-To: <877dg8yxrx.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu,  26 Aug 2021 18:29:54 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 26 Aug 2021 18:29:54 +0200
> Cc: 8035@debbugs.gnu.org
> 
> (file-exists-p "/tmp/comp/src/subdir/../foo.c")
> => nil
> (file-truename "/tmp/comp/src/subdir/../foo.c")
> => "/tmp/comp/dest/foo.c"
> (file-exists-p (file-truename "/tmp/comp/src/subdir/../foo.c"))
> => t
> 
> And this is because:
> 
> static Lisp_Object
> check_file_access (Lisp_Object file, Lisp_Object operation, int amode)
> {
>   file = Fexpand_file_name (file, Qnil);
> 
> I'm guessing it's calling expand-file-name here to resolve "~"?

No, because we always must call expand-file-name before invoking a
libc function that accesses files -- to support file names relative to
their buffer's default-directory.

> I think that `expand-file-name' call in check_file_access should be
> changed to something that just does the "~" expansion.

I don't think we can do that, for the reason explained above.





  reply	other threads:[~2021-08-26 16:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14  3:05 bug#8035: Processing of .. in a file path after going thru symlink spucci
2011-02-19 21:37 ` Glenn Morris
2011-02-20  2:35   ` Steve Pucci
2011-02-20  2:41     ` Steve Pucci
2021-08-26 16:29 ` Lars Ingebrigtsen
2021-08-26 16:44   ` Eli Zaretskii [this message]
2021-08-26 17:03     ` Lars Ingebrigtsen
2021-08-26 17:08       ` Eli Zaretskii
2021-08-26 17:24         ` Lars Ingebrigtsen
2021-08-26 17:30           ` Eli Zaretskii
2021-08-26 16:53   ` Andreas Schwab
2021-08-26 17:04     ` Lars Ingebrigtsen
2021-08-26 17:19       ` Andreas Schwab
2021-08-26 17:30 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfywrw9w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=8035@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=slpnabble@blackberry-hill.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).