From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8035: Processing of .. in a file path after going thru symlink Date: Thu, 26 Aug 2021 19:44:11 +0300 Message-ID: <83sfywrw9w.fsf@gnu.org> References: <30918394.post@talk.nabble.com> <877dg8yxrx.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 8035@debbugs.gnu.org, slpnabble@blackberry-hill.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 18:45:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJIVF-0000N5-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 18:45:21 +0200 Original-Received: from localhost ([::1]:52826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJIVD-00032w-0v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 12:45:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJIUx-0002xD-AD for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJIUw-0004Ca-GE for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJIUw-00063l-2V for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8035 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 8035-submit@debbugs.gnu.org id=B8035.162999628123248 (code B ref 8035); Thu, 26 Aug 2021 16:45:02 +0000 Original-Received: (at 8035) by debbugs.gnu.org; 26 Aug 2021 16:44:41 +0000 Original-Received: from localhost ([127.0.0.1]:50256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJIUb-00062u-I3 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 12:44:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJIUZ-00062h-Iq for 8035@debbugs.gnu.org; Thu, 26 Aug 2021 12:44:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42918) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJIUT-0003si-IE; Thu, 26 Aug 2021 12:44:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJIUS-0007Zj-6W; Thu, 26 Aug 2021 12:44:33 -0400 In-Reply-To: <877dg8yxrx.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 26 Aug 2021 18:29:54 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212730 Archived-At: > From: Lars Ingebrigtsen > Date: Thu, 26 Aug 2021 18:29:54 +0200 > Cc: 8035@debbugs.gnu.org > > (file-exists-p "/tmp/comp/src/subdir/../foo.c") > => nil > (file-truename "/tmp/comp/src/subdir/../foo.c") > => "/tmp/comp/dest/foo.c" > (file-exists-p (file-truename "/tmp/comp/src/subdir/../foo.c")) > => t > > And this is because: > > static Lisp_Object > check_file_access (Lisp_Object file, Lisp_Object operation, int amode) > { > file = Fexpand_file_name (file, Qnil); > > I'm guessing it's calling expand-file-name here to resolve "~"? No, because we always must call expand-file-name before invoking a libc function that accesses files -- to support file names relative to their buffer's default-directory. > I think that `expand-file-name' call in check_file_access should be > changed to something that just does the "~" expansion. I don't think we can do that, for the reason explained above.