unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 52324@debbugs.gnu.org, info@protesilaos.com
Subject: bug#52324: 29.0.50; "Padded" mode line lacks uniform border
Date: Sun, 12 Dec 2021 14:26:19 +0200	[thread overview]
Message-ID: <83sfuynh5g.fsf@gnu.org> (raw)
In-Reply-To: <87v8zu1vwn.fsf@yahoo.com> (message from Po Lu on Sun, 12 Dec 2021 08:58:32 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: info@protesilaos.com,  52324@debbugs.gnu.org
> Date: Sun, 12 Dec 2021 08:58:32 +0800
> 
> The correct solution is to move this code:
> 
>       /* Draw relief if not yet drawn.  */
>       if (!relief_drawn_p && s->face->box != FACE_NO_BOX)
> 	x_draw_glyph_string_box (s);
> 
> To run before drawing the overline.  I tested and it works here, so if
> you have no objections I will make that change in xterm and on the other
> *terms as well.

In w32term.c, I needed to place it before the drawing of the underline
(which is done before drawing the overline).  Otherwise the overline
would be drawn correctly, but underline won't.  If this is what you
had in mind, please go ahead and install the change in all the *term
backends.

Thanks.





  parent reply	other threads:[~2021-12-12 12:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  8:58 bug#52324: 29.0.50; "Padded" mode line lacks uniform border Protesilaos Stavrou
2021-12-06 14:47 ` Eli Zaretskii
2021-12-06 17:13   ` Protesilaos Stavrou
2021-12-11 13:47   ` Eli Zaretskii
2021-12-12  0:58     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-12  2:48       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-12 12:26       ` Eli Zaretskii [this message]
2021-12-12 13:03         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-12 13:12           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-12 13:32             ` Eli Zaretskii
2021-12-12 13:37             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-12 22:20             ` Protesilaos Stavrou
2021-12-13  6:54             ` Protesilaos Stavrou
2021-12-13  7:00               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfuynh5g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52324@debbugs.gnu.org \
    --cc=info@protesilaos.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).