From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52324: 29.0.50; "Padded" mode line lacks uniform border Date: Sun, 12 Dec 2021 14:26:19 +0200 Message-ID: <83sfuynh5g.fsf@gnu.org> References: <877dciyusl.fsf@protesilaos.com> <83k0gh23ka.fsf@gnu.org> <837dcbqmmr.fsf@gnu.org> <87v8zu1vwn.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35939"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52324@debbugs.gnu.org, info@protesilaos.com To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 13:27:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwNwj-00094x-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 13:27:17 +0100 Original-Received: from localhost ([::1]:38924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwNwh-0002c8-I9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 07:27:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNwW-0002bw-4Z for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 07:27:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwNwU-00050B-95 for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 07:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwNwT-0000YC-Op for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 07:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52324 X-GNU-PR-Package: emacs Original-Received: via spool by 52324-submit@debbugs.gnu.org id=B52324.16393119952084 (code B ref 52324); Sun, 12 Dec 2021 12:27:01 +0000 Original-Received: (at 52324) by debbugs.gnu.org; 12 Dec 2021 12:26:35 +0000 Original-Received: from localhost ([127.0.0.1]:50837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNw3-0000XY-GF for submit@debbugs.gnu.org; Sun, 12 Dec 2021 07:26:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNw2-0000XM-DS for 52324@debbugs.gnu.org; Sun, 12 Dec 2021 07:26:34 -0500 Original-Received: from [2001:470:142:3::e] (port=58370 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNvw-0004rh-De; Sun, 12 Dec 2021 07:26:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fGJfUw7IpUObdb1u2u59jMQ12Z03Lj3lLMA+PO8IyOA=; b=WK+Q/DjrvqIL umnR55j5FuAV2VWkglY9IluZo+SZAlYh7cTBZLhjT0U4agpOPW/IskSoHLX0QM0MBD6AyH/YD485j mbD/AnI4UD9OaufoXcwTDFueefRmFbpY0F/OK1Imfv+SgTgoeGJS2JqIbwWY+6nTTS3dWSLWbs9i+ GruFZldho+S1ZmuqjdgPvXWBQYTBBOASJzRK78yphfH7GIfpwvWiHO+16nJNOkDtw7zb5wEIxgB0E jkW73Eq60QbMJ2i96rGswRelKFOf5iW/VRq5pFFV47CEDwfuZ5iS+G2V4qI8RodCFrsgXtxWhNSPM 9Qko26c7UOx7G3YJGt+1Nw==; Original-Received: from [87.69.77.57] (port=4096 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNvv-0005ds-OT; Sun, 12 Dec 2021 07:26:28 -0500 In-Reply-To: <87v8zu1vwn.fsf@yahoo.com> (message from Po Lu on Sun, 12 Dec 2021 08:58:32 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222220 Archived-At: > From: Po Lu > Cc: info@protesilaos.com, 52324@debbugs.gnu.org > Date: Sun, 12 Dec 2021 08:58:32 +0800 > > The correct solution is to move this code: > > /* Draw relief if not yet drawn. */ > if (!relief_drawn_p && s->face->box != FACE_NO_BOX) > x_draw_glyph_string_box (s); > > To run before drawing the overline. I tested and it works here, so if > you have no objections I will make that change in xterm and on the other > *terms as well. In w32term.c, I needed to place it before the drawing of the underline (which is done before drawing the overline). Otherwise the overline would be drawn correctly, but underline won't. If this is what you had in mind, please go ahead and install the change in all the *term backends. Thanks.