unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: luangruo@yahoo.com, larsi@gnus.org, 54562@debbugs.gnu.org
Subject: bug#54562: 28.0.91; Emoji sequence not composed
Date: Tue, 29 Mar 2022 14:44:47 +0300	[thread overview]
Message-ID: <83sfr17zkg.fsf@gnu.org> (raw)
In-Reply-To: <87o81prq93.fsf@gmail.com> (message from Robert Pluim on Tue, 29 Mar 2022 12:45:44 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: luangruo@yahoo.com,  larsi@gnus.org,  54562@debbugs.gnu.org
> Date: Tue, 29 Mar 2022 12:45:44 +0200
> 
>     Eli> I thought about any Mn character whose canonical-combining-class
>     Eli> property is 200 and above.  The COMBINING ENCLOSING <SOMETHING> stuff
>     Eli> will need to be added to that, of course.  And we could have that
>     Eli> option have multiple possible values, not just on/off...
> 
> OK. Would Me be ok for you, or would you specifically want only the
> codepoints from the "Combining Diacritical Marks for Symbols" block?

Using Me is fine with me.

> I guess you'd want options like:
> 
> 'all => combining-class + enclosing
> 'enclosing
> 'combining-class
> 
> (did we want to cover the 'number followed U+20E3 => emoji' case with
> an option too?)

That's a separate issue, IMO, and it can be handled via
auto-composition-emoji-eligible-codepoints, I think?  We could even
tell users to do that by themselves.

> 
>     Eli> Btw, for sequences that include a base character and 2 or more
>     Eli> diacritics, selecting a font that supports the first diacritic (the
>     Eli> one which triggers the composition) might not be enough, since the
>     Eli> rest of the diacritics could be absent from that font.  Instead, we'd
>     Eli> need something like "find the font for each one of them and then use
>     Eli> the one which supports the largest subset of them".
> 
> font_range currently only has access to the first diacritic, so that
> would be a bigger change. And that subset had better have the same
> size as the number of unique diacritics, otherwise itʼs unlikely to
> work.

We could perhaps avoid the complexity by rewriting the composition
rule for diacritics.  Instead of "\\c.\\c^+" with 1-character
look-back, we could have several rules:

   "\\c.\\c^\\c^\\c^\\c^" with 4-character look-back
   "\\c.\\c^\\c^\\c^+"    with 3-character look-back
   "\\c.\\c^\\c^+"        with 2-character look-back
   "\\c.\\c^+"            with 1-character look-back

(in that order).  I didn't test this, but if it works, maybe it could
solve the problem without any deep changes on the C level.





  reply	other threads:[~2022-03-29 11:44 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87bkxu8k7t.fsf.ref@yahoo.com>
2022-03-25  9:17 ` bug#54562: 28.0.91; Emoji sequence not composed Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 10:27   ` Eli Zaretskii
2022-03-25 10:32     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 10:54       ` Robert Pluim
2022-03-25 11:47         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 12:15           ` Eli Zaretskii
2022-03-25 12:46             ` Andreas Schwab
2022-03-25 13:05               ` Eli Zaretskii
2022-03-25 13:14                 ` Andreas Schwab
2022-03-25 13:30                   ` Robert Pluim
2022-03-25 13:57                     ` Andreas Schwab
2022-03-25 13:44                   ` Eli Zaretskii
2022-03-25 14:03                     ` Andreas Schwab
2022-03-25 14:05             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 14:14               ` Robert Pluim
2022-03-26  1:16                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-26  5:56                   ` Eli Zaretskii
2022-03-26 16:51                     ` Lars Ingebrigtsen
2022-03-27  0:32                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-27 15:10                         ` Robert Pluim
2022-03-28  0:19                           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-28  7:47                             ` Robert Pluim
2022-03-28 11:51                               ` Eli Zaretskii
2022-03-28 12:46                                 ` Robert Pluim
2022-03-28 13:12                                   ` Eli Zaretskii
2022-03-28 14:59                                     ` Robert Pluim
2022-03-28 16:07                                       ` Eli Zaretskii
2022-03-29 10:45                                         ` Robert Pluim
2022-03-29 11:44                                           ` Eli Zaretskii [this message]
2022-03-29 14:50                                             ` Robert Pluim
2022-03-29 15:42                                               ` Eli Zaretskii
2022-03-29 15:59                                                 ` Robert Pluim
2022-03-29 16:49                                                   ` Eli Zaretskii
2022-03-28 13:19                                   ` Andreas Schwab
2022-03-28 15:01                                     ` Robert Pluim
2022-03-28 15:35                                       ` Andreas Schwab
2022-03-28 16:11                                         ` Eli Zaretskii
2022-03-28 16:20                                           ` Andreas Schwab
2022-03-28 16:26                                             ` Robert Pluim
2022-03-28 16:41                                               ` Andreas Schwab
2022-03-28 17:10                                             ` Eli Zaretskii
2022-03-28 17:14                                               ` Eli Zaretskii
2022-03-28 17:39                                               ` Andreas Schwab
2022-03-28 18:12                                                 ` Eli Zaretskii
2022-03-28 18:14                                                   ` Andreas Schwab
2022-03-28 18:15                                                 ` Eli Zaretskii
2022-03-25 11:23       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfr17zkg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54562@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).