unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: luangruo@yahoo.com, larsi@gnus.org, 54562@debbugs.gnu.org
Subject: bug#54562: 28.0.91; Emoji sequence not composed
Date: Mon, 28 Mar 2022 14:51:49 +0300	[thread overview]
Message-ID: <838rsu9twq.fsf@gnu.org> (raw)
In-Reply-To: <87mthatt5h.fsf@gmail.com> (message from Robert Pluim on Mon, 28 Mar 2022 09:47:54 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  54562@debbugs.gnu.org,  Eli
>  Zaretskii <eliz@gnu.org>
> Date: Mon, 28 Mar 2022 09:47:54 +0200
> 
> OK. So it sounds like we should perhaps look at doing composition for
> the codepoints in that block by doing face lookup based on the
> combining character rather than the base character.

I guess we should try.  It should be optional behavior, because Emacs
never did that, and I cannot predict what will that do to all the
different use cases where we compose text, and thus whether users will
like that in all the cases.  It could, for example, mean that a
particular Latin character with a diacritic will be displayed with a
font that's different from the rest of the Latin text, which some
users might consider worse than seeing just the base character in the
"expected" font.  And that's just the simplest use case.

And I think "based on combining character" is not the correct
definition.  We should allow selection of the font based on the
character that triggered the composition, i.e. the character whose
slot in composition-function-table stores the rule which we are using
to produce the composition.  Like we already do for Emoji.  For
combining characters, the default is that the combining character is
that trigger.  By contrast, today we use the font for the first
character in the composition sequence (NOT the base character, as I
incorrectly wrote earlier, although in practice it is the same for
Latin).

> Eli, should we look at doing that for other combining characters,
> such as Andreas' 0308?

"Look at" in what sense?





  reply	other threads:[~2022-03-28 11:51 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87bkxu8k7t.fsf.ref@yahoo.com>
2022-03-25  9:17 ` bug#54562: 28.0.91; Emoji sequence not composed Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 10:27   ` Eli Zaretskii
2022-03-25 10:32     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 10:54       ` Robert Pluim
2022-03-25 11:47         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 12:15           ` Eli Zaretskii
2022-03-25 12:46             ` Andreas Schwab
2022-03-25 13:05               ` Eli Zaretskii
2022-03-25 13:14                 ` Andreas Schwab
2022-03-25 13:30                   ` Robert Pluim
2022-03-25 13:57                     ` Andreas Schwab
2022-03-25 13:44                   ` Eli Zaretskii
2022-03-25 14:03                     ` Andreas Schwab
2022-03-25 14:05             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 14:14               ` Robert Pluim
2022-03-26  1:16                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-26  5:56                   ` Eli Zaretskii
2022-03-26 16:51                     ` Lars Ingebrigtsen
2022-03-27  0:32                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-27 15:10                         ` Robert Pluim
2022-03-28  0:19                           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-28  7:47                             ` Robert Pluim
2022-03-28 11:51                               ` Eli Zaretskii [this message]
2022-03-28 12:46                                 ` Robert Pluim
2022-03-28 13:12                                   ` Eli Zaretskii
2022-03-28 14:59                                     ` Robert Pluim
2022-03-28 16:07                                       ` Eli Zaretskii
2022-03-29 10:45                                         ` Robert Pluim
2022-03-29 11:44                                           ` Eli Zaretskii
2022-03-29 14:50                                             ` Robert Pluim
2022-03-29 15:42                                               ` Eli Zaretskii
2022-03-29 15:59                                                 ` Robert Pluim
2022-03-29 16:49                                                   ` Eli Zaretskii
2022-03-28 13:19                                   ` Andreas Schwab
2022-03-28 15:01                                     ` Robert Pluim
2022-03-28 15:35                                       ` Andreas Schwab
2022-03-28 16:11                                         ` Eli Zaretskii
2022-03-28 16:20                                           ` Andreas Schwab
2022-03-28 16:26                                             ` Robert Pluim
2022-03-28 16:41                                               ` Andreas Schwab
2022-03-28 17:10                                             ` Eli Zaretskii
2022-03-28 17:14                                               ` Eli Zaretskii
2022-03-28 17:39                                               ` Andreas Schwab
2022-03-28 18:12                                                 ` Eli Zaretskii
2022-03-28 18:14                                                   ` Andreas Schwab
2022-03-28 18:15                                                 ` Eli Zaretskii
2022-03-25 11:23       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rsu9twq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54562@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).