* bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github
@ 2023-02-02 6:17 Yuan Fu
2023-02-02 8:41 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-02 9:03 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Yuan Fu @ 2023-02-02 6:17 UTC (permalink / raw)
To: 61223; +Cc: eliz, dgutov
X-Debbugs-CC: eliz@gnu.org, dgutov@yandex.ru
--text follows this line--
I noticed that treesit-install-language-grammar now automatically builds
the repository url from github:
(let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
(read-string
"Enter the URL of the Git repository of the language grammar: "
(and (treesit--check-repo-url repo-default) repo-default)))
AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
include “official” grammar repositories in
treesit-language-source-alist. Was there a discussion that I missed?
This is a nice feature, but I’d hate having to remove it later, after
users have noticed it and started using/depending on it, due to some GNU
policy.
Yuan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github
2023-02-02 6:17 bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github Yuan Fu
@ 2023-02-02 8:41 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-02 9:03 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-02-02 8:41 UTC (permalink / raw)
To: Yuan Fu; +Cc: eliz, 61223, dgutov
On Feb 2, 2023, at 14:19, Yuan Fu <casouri@gmail.com> wrote:
>
> X-Debbugs-CC: eliz@gnu.org, dgutov@yandex.ru
> --text follows this line--
> I noticed that treesit-install-language-grammar now automatically builds
> the repository url from github:
>
> (let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
> (read-string
> "Enter the URL of the Git repository of the language grammar: "
> (and (treesit--check-repo-url repo-default) repo-default)))
>
>
> AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
> include “official” grammar repositories in
> treesit-language-source-alist. Was there a discussion that I missed?
>
> This is a nice feature, but I’d hate having to remove it later, after
> users have noticed it and started using/depending on it, due to some GNU
> policy.
>
> Yuan
Hello Yuan,
I think this is the result of installing the proposed patch from bug#61051, which Eli approved and Dmitry installed. I had my doubts on the github reference but didn’t ask back then.
Best,
RY
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github
2023-02-02 6:17 bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github Yuan Fu
2023-02-02 8:41 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-02-02 9:03 ` Eli Zaretskii
2023-02-03 2:40 ` Yuan Fu
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2023-02-02 9:03 UTC (permalink / raw)
To: Yuan Fu; +Cc: 61223, dgutov
> Cc: eliz@gnu.org, dgutov@yandex.ru
> From: Yuan Fu <casouri@gmail.com>
> Date: Wed, 1 Feb 2023 22:17:56 -0800
>
> I noticed that treesit-install-language-grammar now automatically builds
> the repository url from github:
>
> (let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
> (read-string
> "Enter the URL of the Git repository of the language grammar: "
> (and (treesit--check-repo-url repo-default) repo-default)))
>
>
> AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
> include “official” grammar repositories in
> treesit-language-source-alist. Was there a discussion that I missed?
>
> This is a nice feature, but I’d hate having to remove it later, after
> users have noticed it and started using/depending on it, due to some GNU
> policy.
I don't see a problem here: it's just the default we offer when a
grammar is available from the Tree-sitter site. It's a far cry from
having a database full of GitHub URLs that we'd need to maintain and
keep up to date.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github
2023-02-02 9:03 ` Eli Zaretskii
@ 2023-02-03 2:40 ` Yuan Fu
0 siblings, 0 replies; 4+ messages in thread
From: Yuan Fu @ 2023-02-03 2:40 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 61223-done, 61223, Dmitry Gutov
> Hello Yuan,
>
> I think this is the result of installing the proposed patch from bug#61051, which Eli approved and Dmitry installed. I had my doubts on the github reference but didn’t ask back then.
>
> Best,
>
>
> RY
> On Feb 2, 2023, at 1:03 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> I don't see a problem here: it's just the default we offer when a
> grammar is available from the Tree-sitter site. It's a far cry from
> having a database full of GitHub URLs that we'd need to maintain and
> keep up to date.
That’s very good news :-) Closing.
Yuan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-03 2:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-02 6:17 bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github Yuan Fu
2023-02-02 8:41 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-02 9:03 ` Eli Zaretskii
2023-02-03 2:40 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).