From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Melo <tmdmelo@gmail.com>
Cc: 63754-done@debbugs.gnu.org
Subject: bug#63754: 29.0.91; tmm breaks when tmm-completion-prompt is nil
Date: Sun, 28 May 2023 08:22:38 +0300 [thread overview]
Message-ID: <83sfbhhvxd.fsf@gnu.org> (raw)
In-Reply-To: <CABpoeKhMdzfO+SqKMCDPTzpJ4kPp_3=Oj8=VMQ66bXSUFJY8Gg@mail.gmail.com> (message from Thiago Melo on Sat, 27 May 2023 19:48:54 +0000)
> From: Thiago Melo <tmdmelo@gmail.com>
> Date: Sat, 27 May 2023 19:48:54 +0000
> Cc: 63754@debbugs.gnu.org
>
> On Sat, May 27, 2023 at 5:14 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > Thanks. This was caused by a change in the completion heading line in
> > Emacs 29: it is now a customizable format string, and can be nil. So
> > the method used by tmm.el for finding the prompt (so it could delete
> > it) is no longer workable, and must be replaced by a different method.
> >
> > Should be fixed now on the emacs-29 branch.
>
> Cool. I've tested, it's working nicely. Thanks for the fix.
Thanks for testing, I'm therefore closing this bug.
> > (I also fixed it to work
> > when 'tmm-mid-prompt' is nil, something that seems to have been broken
> > since about forever -- I found that bug while testing the patch,
> > because the patch has to work also when 'tmm-mid-prompt' is nil, and
> > there are no menu shortcuts shown.)
>
> Sorry if my comment is out of place, but I also gave a try to
> `tmm-mid-prompt' = nil. Since it disables the tmm shortcuts, maybe it
> would be more intuitive to let users input keys and do completion at
> the minibuffer in this situation? (unless I'm missing some unwanted
> side effect here)
>
> With this little change, for example:
I don't know. The original completion works on the shortcuts, AFAIU,
and thus makes no sense when tmm-mid-prompt is nil. When that
variable is nil, the user needs to use the arrow keys to select the
menu items. If someone wants to add a completion feature to that, I
don't mind, but I don't know enough about tmm to tell, and such a
change is definitely not for the release branch.
If someone here has an opinion on this last suggestion, please speak
up.
next prev parent reply other threads:[~2023-05-28 5:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 14:53 bug#63754: 29.0.91; tmm breaks when tmm-completion-prompt is nil Thiago Melo
2023-05-27 17:15 ` Eli Zaretskii
2023-05-27 19:48 ` Thiago Melo
2023-05-28 5:22 ` Eli Zaretskii [this message]
2023-05-29 16:37 ` Juri Linkov
2023-05-29 17:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfbhhvxd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63754-done@debbugs.gnu.org \
--cc=tmdmelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).