From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63754: 29.0.91; tmm breaks when tmm-completion-prompt is nil Date: Sun, 28 May 2023 08:22:38 +0300 Message-ID: <83sfbhhvxd.fsf@gnu.org> References: <831qj1k867.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4118"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63754-done@debbugs.gnu.org To: Thiago Melo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 28 07:23:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q38sG-0000tT-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 May 2023 07:23:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q38ry-0007Pu-S0; Sun, 28 May 2023 01:23:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q38rv-0007P7-CS for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 01:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q38rv-0002N1-4e for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 01:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q38ru-0000K8-RS for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 01:23:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 May 2023 05:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63754 X-GNU-PR-Package: emacs Mail-Followup-To: 63754@debbugs.gnu.org, eliz@gnu.org, tmdmelo@gmail.com Original-Received: via spool by 63754-done@debbugs.gnu.org id=D63754.16852513321164 (code D ref 63754); Sun, 28 May 2023 05:23:02 +0000 Original-Received: (at 63754-done) by debbugs.gnu.org; 28 May 2023 05:22:12 +0000 Original-Received: from localhost ([127.0.0.1]:52987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q38r6-0000Ii-Aq for submit@debbugs.gnu.org; Sun, 28 May 2023 01:22:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q38r4-0000IW-5u for 63754-done@debbugs.gnu.org; Sun, 28 May 2023 01:22:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q38qx-0002EP-SF; Sun, 28 May 2023 01:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=WLGGWBt0pEjSjtWJUMTfBqAZ9OkSdm2l5Mzw2TAYls8=; b=UWKshvPDOsdaOUQNULZd YNZiOqJf+Yc7IY4jMcCE4Y4gaIxvxJDx/BY/1DfAA8bACIElGyh1FPZqpXmCND1rsx778zh5auVNP eLwXqvnKIjJjAWJWy13AX0IjWkSRB+xUgb3Y3EEKpObB+6c3XoRwI24TvVmUNciQv0Y/ad82SmT0+ WcFdt4h2smDiam0q+3Rp5y7P7h6fsED1zyipGAxzn8CFowUbanoSDXZfrw4uvHgiHfCVxGxQDA273 kaLj0CDdvFVUMAf8uhK/IOTm0aInGB3UQI/tWp1CAmXF2ZFB01pMmk1owbpIWJLDPQLofWUiOig8l U682OzdzTplD9Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q38qv-0007BK-TZ; Sun, 28 May 2023 01:22:03 -0400 In-Reply-To: (message from Thiago Melo on Sat, 27 May 2023 19:48:54 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262508 Archived-At: > From: Thiago Melo > Date: Sat, 27 May 2023 19:48:54 +0000 > Cc: 63754@debbugs.gnu.org > > On Sat, May 27, 2023 at 5:14 PM Eli Zaretskii wrote: > > Thanks. This was caused by a change in the completion heading line in > > Emacs 29: it is now a customizable format string, and can be nil. So > > the method used by tmm.el for finding the prompt (so it could delete > > it) is no longer workable, and must be replaced by a different method. > > > > Should be fixed now on the emacs-29 branch. > > Cool. I've tested, it's working nicely. Thanks for the fix. Thanks for testing, I'm therefore closing this bug. > > (I also fixed it to work > > when 'tmm-mid-prompt' is nil, something that seems to have been broken > > since about forever -- I found that bug while testing the patch, > > because the patch has to work also when 'tmm-mid-prompt' is nil, and > > there are no menu shortcuts shown.) > > Sorry if my comment is out of place, but I also gave a try to > `tmm-mid-prompt' = nil. Since it disables the tmm shortcuts, maybe it > would be more intuitive to let users input keys and do completion at > the minibuffer in this situation? (unless I'm missing some unwanted > side effect here) > > With this little change, for example: I don't know. The original completion works on the shortcuts, AFAIU, and thus makes no sense when tmm-mid-prompt is nil. When that variable is nil, the user needs to use the arrow keys to select the menu items. If someone wants to add a completion feature to that, I don't mind, but I don't know enough about tmm to tell, and such a change is definitely not for the release branch. If someone here has an opinion on this last suggestion, please speak up.