* bug#65977: 30.0.50; save-place-ignore-files-regexp missing choice
@ 2023-09-14 11:23 Mauro Aranda
2023-09-14 11:25 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-14 11:23 UTC (permalink / raw)
To: 65977
The docstring of save-place-ignore-files-regexp says its value can be
nil, but its :type isn't a choice between nil and regexp.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#65977: 30.0.50; save-place-ignore-files-regexp missing choice
2023-09-14 11:23 bug#65977: 30.0.50; save-place-ignore-files-regexp missing choice Mauro Aranda
@ 2023-09-14 11:25 ` Mauro Aranda
2023-09-14 13:18 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-14 11:25 UTC (permalink / raw)
To: 65977
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
tags 65977 patch
quit
Patch attached.
[-- Attachment #2: 0001-Fix-defcustom-in-saveplace.el-Bug-65977.patch --]
[-- Type: text/x-patch, Size: 889 bytes --]
From be7e28d90e5b0d0a03a6bbd54e5ec9cc915cbe6e Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Thu, 14 Sep 2023 08:24:43 -0300
Subject: [PATCH] Fix defcustom in saveplace.el (Bug#65977)
* lisp/saveplace.el (save-place-ignore-files-regexp): Allow nil.
---
lisp/saveplace.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/saveplace.el b/lisp/saveplace.el
index a28de6f63a8..9004d489e9a 100644
--- a/lisp/saveplace.el
+++ b/lisp/saveplace.el
@@ -201,7 +201,8 @@ save-place-ignore-files-regexp
automatically created by the VCS. If set to nil, this feature is
disabled, i.e., the position is recorded for all files."
:version "24.1"
- :type 'regexp)
+ :type '(choice (const :tag "Record position for all files" nil)
+ regexp))
(declare-function dired-current-directory "dired" (&optional localp))
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#65977: 30.0.50; save-place-ignore-files-regexp missing choice
2023-09-14 11:25 ` Mauro Aranda
@ 2023-09-14 13:18 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-09-14 13:18 UTC (permalink / raw)
To: Mauro Aranda; +Cc: 65977-done
> Date: Thu, 14 Sep 2023 08:25:55 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
>
> Patch attached.
Thanks, installed on the emacs-29 branch, and closing the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-14 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 11:23 bug#65977: 30.0.50; save-place-ignore-files-regexp missing choice Mauro Aranda
2023-09-14 11:25 ` Mauro Aranda
2023-09-14 13:18 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).