unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org, peder@klingenberg.no, 42095@debbugs.gnu.org
Subject: bug#42095: 28.0.50; Build fails on Windows/MinGW64
Date: Mon, 29 Jun 2020 17:13:48 +0300	[thread overview]
Message-ID: <83r1ty0xk3.fsf__13704.0355753683$1593440170$gmane$org@gnu.org> (raw)
In-Reply-To: <e51b4ec2-2763-8d48-9724-2e26fe405373@cs.ucla.edu> (message from Paul Eggert on Sun, 28 Jun 2020 13:34:36 -0700)

> Cc: 42095@debbugs.gnu.org, "Peder O. Klingenberg" <peder@klingenberg.no>,
>  Gnulib bugs <bug-gnulib@gnu.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sun, 28 Jun 2020 13:34:36 -0700
> 
> As I understand it the basic issue here is that we want O_CLOEXEC support even
> on platforms that lack it, and we don't want all the calling software to play
> games with "#ifdef O_CLOEXEC" and the like.

AFAICT, O_CLOEXEC is already supported by the 'open' implementation we
use on MS-Windows ('sys_open' in w32.c), so I think we are good there.

> I attempted to work around this particular problem by installing the attached
> workaround into Gnulib and updating Emacs accordingly. Please give it a try.

Thanks, it builds fine.

> Perhaps this should be fixed more systematically in Gnulib instead of worked
> around, but I suppose that might entail some merging between Emacs's and
> Gnulib's ways of dealing with file names under MS-Windows and I'll leave it to
> the MS-Windows experts to figure out how to do that, or whether they want to do
> it at all.

As long as config.h is included in a Gnulib source file that calls
'open' (and AFAIK all Gnulib files do that), the call will be
redirected to 'sys_open' mentioned above, and everything is supposed
to "just work".





  parent reply	other threads:[~2020-06-29 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 21:28 bug#42095: 28.0.50; Build fails on Windows/MinGW64 Peder O. Klingenberg
2020-06-28 15:48 ` Eli Zaretskii
2020-06-28 19:36   ` Eli Zaretskii
2020-06-28 20:35     ` Paul Eggert
2020-06-29  2:28       ` Eli Zaretskii
2020-06-29  6:56         ` Paul Eggert
2020-06-29 14:52           ` Eli Zaretskii
2020-06-29 16:56             ` Paul Eggert
2020-06-29 18:45               ` Eli Zaretskii
2020-06-28 20:34   ` Paul Eggert
     [not found]   ` <e51b4ec2-2763-8d48-9724-2e26fe405373@cs.ucla.edu>
2020-06-29 14:13     ` Eli Zaretskii [this message]
     [not found]     ` <83r1ty0xk3.fsf@gnu.org>
2020-06-29 16:59       ` Paul Eggert
2020-06-28 22:20 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='83r1ty0xk3.fsf__13704.0355753683$1593440170$gmane$org@gnu.org' \
    --to=eliz@gnu.org \
    --cc=42095@debbugs.gnu.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=peder@klingenberg.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).