From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42095: 28.0.50; Build fails on Windows/MinGW64 Date: Mon, 29 Jun 2020 17:13:48 +0300 Message-ID: <83r1ty0xk3.fsf__13704.0355753683$1593440170$gmane$org@gnu.org> References: <878sg819n2.fsf@klingenberg.no> <83bll32ntx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="79480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bug-gnulib@gnu.org, peder@klingenberg.no, 42095@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 29 16:16:06 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jpuZo-000KVg-0D for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jun 2020 16:16:04 +0200 Original-Received: from localhost ([::1]:49796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpuZn-00054r-0u for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jun 2020 10:16:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpuYo-0003nU-T0 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 10:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpuYo-0005F3-J3 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpuYo-0005Ha-DH for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2020 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42095 X-GNU-PR-Package: emacs Original-Received: via spool by 42095-submit@debbugs.gnu.org id=B42095.159344005220208 (code B ref 42095); Mon, 29 Jun 2020 14:15:02 +0000 Original-Received: (at 42095) by debbugs.gnu.org; 29 Jun 2020 14:14:12 +0000 Original-Received: from localhost ([127.0.0.1]:49029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpuY0-0005Fs-3U for submit@debbugs.gnu.org; Mon, 29 Jun 2020 10:14:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpuXu-0005FG-To for 42095@debbugs.gnu.org; Mon, 29 Jun 2020 10:14:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60030) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpuXo-00055K-4p; Mon, 29 Jun 2020 10:14:00 -0400 Original-Received: from [176.228.60.248] (port=2400 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpuXm-0002Vp-NH; Mon, 29 Jun 2020 10:13:59 -0400 In-Reply-To: (message from Paul Eggert on Sun, 28 Jun 2020 13:34:36 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182526 Archived-At: > Cc: 42095@debbugs.gnu.org, "Peder O. Klingenberg" , > Gnulib bugs > From: Paul Eggert > Date: Sun, 28 Jun 2020 13:34:36 -0700 > > As I understand it the basic issue here is that we want O_CLOEXEC support even > on platforms that lack it, and we don't want all the calling software to play > games with "#ifdef O_CLOEXEC" and the like. AFAICT, O_CLOEXEC is already supported by the 'open' implementation we use on MS-Windows ('sys_open' in w32.c), so I think we are good there. > I attempted to work around this particular problem by installing the attached > workaround into Gnulib and updating Emacs accordingly. Please give it a try. Thanks, it builds fine. > Perhaps this should be fixed more systematically in Gnulib instead of worked > around, but I suppose that might entail some merging between Emacs's and > Gnulib's ways of dealing with file names under MS-Windows and I'll leave it to > the MS-Windows experts to figure out how to do that, or whether they want to do > it at all. As long as config.h is included in a Gnulib source file that calls 'open' (and AFAIK all Gnulib files do that), the call will be redirected to 'sys_open' mentioned above, and everything is supposed to "just work".