unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 48479@debbugs.gnu.org
Subject: bug#48479: 28.0.50; Crash on `read--expression'
Date: Tue, 18 May 2021 14:29:06 +0300	[thread overview]
Message-ID: <83r1i4s2kd.fsf@gnu.org> (raw)
In-Reply-To: <266671C9-C9F1-4CF1-AA2C-F8D6FD64C470@acm.org> (message from Mattias Engdegård on Mon, 17 May 2021 22:01:10 +0200)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Mon, 17 May 2021 22:01:10 +0200
> Cc: 48479@debbugs.gnu.org
> 
> 17 maj 2021 kl. 17.14 skrev Eli Zaretskii <eliz@gnu.org>:
> 
> > Thanks, this was caused by a recent addition of the :success handler.
> > I tried to fix that on the master branch now.
> 
> Thank you for fixing that, and sorry about the oversight.

No sweat.

> It prompts the question why we are so permissive in the first place -- a nil handler is malformed and always a mistake. Raising an error is probably more helpful. Although someone may be relying on this undocumented behaviour it sounds unlikely. Given that it has elicited a byte-compiler warning for a very long time (probably something like 17 years), we ought to be forgiven for turning it into an error now, wouldn't we?

What would be the advantage of making it an error?





  reply	other threads:[~2021-05-18 11:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 11:39 bug#48479: 28.0.50; Crash on `read--expression' Jean Louis
2021-05-17 15:14 ` Eli Zaretskii
2021-05-17 20:01   ` Mattias Engdegård
2021-05-18 11:29     ` Eli Zaretskii [this message]
2021-05-18 15:00       ` Mattias Engdegård
2021-05-18 15:09         ` Eli Zaretskii
2021-05-18 15:42           ` Mattias Engdegård
2021-05-18 16:45             ` Eli Zaretskii
2021-05-18 17:12               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-18 17:46                 ` Andreas Schwab
2021-05-19 16:36                   ` Mattias Engdegård
2021-05-19 14:53                 ` Lars Ingebrigtsen
2021-05-19 15:13                   ` Eli Zaretskii
2021-05-19 16:33                   ` Mattias Engdegård
2021-05-19 18:58                     ` Lars Ingebrigtsen
2021-05-19 20:18                       ` Mattias Engdegård
2021-05-25  5:05                         ` Lars Ingebrigtsen
2021-05-25  8:29                           ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1i4s2kd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48479@debbugs.gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).