From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48479: 28.0.50; Crash on `read--expression' Date: Tue, 18 May 2021 14:29:06 +0300 Message-ID: <83r1i4s2kd.fsf@gnu.org> References: <8635ulvbbx.fsf@protected.rcdrun.com> <835yzhtmt7.fsf@gnu.org> <266671C9-C9F1-4CF1-AA2C-F8D6FD64C470@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48479@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 18 13:30:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lixvR-0005eQ-To for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 13:30:13 +0200 Original-Received: from localhost ([::1]:32918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lixvQ-0000Am-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 07:30:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lixvH-0000AU-2W for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 07:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lixvG-0005mg-P8 for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 07:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lixvG-0002NE-KB for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 07:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 May 2021 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48479 X-GNU-PR-Package: emacs Original-Received: via spool by 48479-submit@debbugs.gnu.org id=B48479.16213373509031 (code B ref 48479); Tue, 18 May 2021 11:30:02 +0000 Original-Received: (at 48479) by debbugs.gnu.org; 18 May 2021 11:29:10 +0000 Original-Received: from localhost ([127.0.0.1]:54579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lixuQ-0002Lb-93 for submit@debbugs.gnu.org; Tue, 18 May 2021 07:29:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lixuM-0002L5-De for 48479@debbugs.gnu.org; Tue, 18 May 2021 07:29:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60230) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lixuG-00057F-5V; Tue, 18 May 2021 07:29:00 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lixuF-00077v-Ff; Tue, 18 May 2021 07:28:59 -0400 In-Reply-To: <266671C9-C9F1-4CF1-AA2C-F8D6FD64C470@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 17 May 2021 22:01:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206770 Archived-At: > From: Mattias Engdegård > Date: Mon, 17 May 2021 22:01:10 +0200 > Cc: 48479@debbugs.gnu.org > > 17 maj 2021 kl. 17.14 skrev Eli Zaretskii : > > > Thanks, this was caused by a recent addition of the :success handler. > > I tried to fix that on the master branch now. > > Thank you for fixing that, and sorry about the oversight. No sweat. > It prompts the question why we are so permissive in the first place -- a nil handler is malformed and always a mistake. Raising an error is probably more helpful. Although someone may be relying on this undocumented behaviour it sounds unlikely. Given that it has elicited a byte-compiler warning for a very long time (probably something like 17 years), we ought to be forgiven for turning it into an error now, wouldn't we? What would be the advantage of making it an error?