unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: larsi@gnus.org, 12436@debbugs.gnu.org
Subject: bug#12436: 24.2.50; rename `(next|previous)-multiframe-window'
Date: Thu, 31 Oct 2019 16:05:46 +0200	[thread overview]
Message-ID: <83pnidnh6t.fsf@gnu.org> (raw)
In-Reply-To: <878sp1x3vm.fsf@joffe.skangas.se> (message from Stefan Kangas on Wed, 30 Oct 2019 23:30:53 +0100)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 30 Oct 2019 23:30:53 +0100
> Cc: 12436@debbugs.gnu.org
> 
> >> Rename these commands and deprecate the old names.  There is no such
> >> thing as a multiframe window, which would mean a window on more than one
> >> frame.  These commands should be called something like:
> >> `(next|previous)-window-any-frame'.
> >
> > I agree.  Any objections?  There does not seem to be many users of these
> > functions:
> >
> > ./frame.el:522:(defun next-multiframe-window ()
> > ./frame.el:530:(defun previous-multiframe-window ()
> > ./term/ns-win.el:105:(define-key global-map [?\s-'] 'next-multiframe-window)

They are commands, not functions.  So counting the number of their
calls in the code is not an objective method of estimating their
popularity.

> Makes sense to me.  Any objections to the below patch?

I don't object, although I do wonder what could be the point of
renaming commands which were known under these names for the last
28(!) years.  Given their age, perhaps consider not obsoleting the old
names: who knows whether someone out there has these names burned into
their muscle memory?

Thanks.





  parent reply	other threads:[~2019-10-31 14:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 16:30 bug#12436: 24.2.50; rename `(next|previous)-multiframe-window' Drew Adams
2016-04-28 17:23 ` Lars Ingebrigtsen
2019-10-30 22:30   ` Stefan Kangas
2019-10-30 22:46     ` Lars Ingebrigtsen
2019-10-30 23:20     ` Drew Adams
2019-10-31 14:05     ` Eli Zaretskii [this message]
2019-11-02  1:37       ` Stefan Kangas
2019-11-05 23:51         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pnidnh6t.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12436@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).