From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12436: 24.2.50; rename `(next|previous)-multiframe-window' Date: Thu, 31 Oct 2019 16:05:46 +0200 Message-ID: <83pnidnh6t.fsf@gnu.org> References: <41448D3E81B245CAA20C88FD41B31D26@us.oracle.com> <87fuu57img.fsf@gnus.org> <878sp1x3vm.fsf@joffe.skangas.se> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="108639"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, 12436@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 15:10:52 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQBA0-000S2X-Fu for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 15:10:48 +0100 Original-Received: from localhost ([::1]:50424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQB9x-0000e5-Fy for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 10:10:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44017) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQB5Q-0002hF-N7 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQB5P-0008CW-HW for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45090) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQB5O-0008C0-O4 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQB5O-00051L-GL for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2019 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12436 X-GNU-PR-Package: emacs Original-Received: via spool by 12436-submit@debbugs.gnu.org id=B12436.157253075419284 (code B ref 12436); Thu, 31 Oct 2019 14:06:02 +0000 Original-Received: (at 12436) by debbugs.gnu.org; 31 Oct 2019 14:05:54 +0000 Original-Received: from localhost ([127.0.0.1]:53911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQB5G-00050y-FZ for submit@debbugs.gnu.org; Thu, 31 Oct 2019 10:05:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQB5E-00050j-VQ for 12436@debbugs.gnu.org; Thu, 31 Oct 2019 10:05:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQB59-0007EZ-EE; Thu, 31 Oct 2019 10:05:47 -0400 Original-Received: from [176.228.60.248] (port=4505 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQB58-00025F-NM; Thu, 31 Oct 2019 10:05:47 -0400 In-reply-to: <878sp1x3vm.fsf@joffe.skangas.se> (message from Stefan Kangas on Wed, 30 Oct 2019 23:30:53 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170509 Archived-At: > From: Stefan Kangas > Date: Wed, 30 Oct 2019 23:30:53 +0100 > Cc: 12436@debbugs.gnu.org > > >> Rename these commands and deprecate the old names. There is no such > >> thing as a multiframe window, which would mean a window on more than one > >> frame. These commands should be called something like: > >> `(next|previous)-window-any-frame'. > > > > I agree. Any objections? There does not seem to be many users of these > > functions: > > > > ./frame.el:522:(defun next-multiframe-window () > > ./frame.el:530:(defun previous-multiframe-window () > > ./term/ns-win.el:105:(define-key global-map [?\s-'] 'next-multiframe-window) They are commands, not functions. So counting the number of their calls in the code is not an objective method of estimating their popularity. > Makes sense to me. Any objections to the below patch? I don't object, although I do wonder what could be the point of renaming commands which were known under these names for the last 28(!) years. Given their age, perhaps consider not obsoleting the old names: who knows whether someone out there has these names burned into their muscle memory? Thanks.