* bug#3987: marked as done (23.1; Rmail summary missing dates when case-fold-search is nil)
2009-07-31 0:01 ` bug#3987: 23.1; Rmail summary missing dates when case-fold-search is nil Christopher Neufeld
2009-08-01 8:24 ` Eli Zaretskii
@ 2009-08-01 8:30 ` Emacs bug Tracking System
1 sibling, 0 replies; 3+ messages in thread
From: Emacs bug Tracking System @ 2009-08-01 8:30 UTC (permalink / raw)
To: Eli Zaretskii
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
Your message dated Sat, 01 Aug 2009 11:23:04 +0300
with message-id <83prbgosd3.fsf@gnu.org>
and subject line Re: bug#3987: 23.1; Rmail summary missing dates when case-fold-search is nil
has caused the Emacs bug report #3987,
regarding 23.1; Rmail summary missing dates when case-fold-search is nil
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
3987: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3987
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 4619 bytes --]
From: Christopher Neufeld <emacsbugs0001@cneufeld.ca>
From: Christopher Neufeld <emacsbugs0001@cneufeld.ca>
To: bug-gnu-emacs@gnu.org
Subject: 23.1; Rmail summary missing dates when case-fold-search is nil
Date: Thu, 30 Jul 2009 20:01:07 -0400
Message-ID: <200907310001.n6V017Vf001720@cneufeld.ca>
In GNU Emacs 23.1.1 (x86_64-unknown-linux-gnu, X toolkit)
of 2009-07-30 on londo.cneufeld.ca
configured using `configure '--prefix=/usr' '--with-x' '--with-xpm' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--enable-font-backend' '--with-xft' '--with-freetype' '--with-x-toolkit=lucid''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: nil
default-enable-multibyte-characters: t
Major mode: RMAIL
Minor modes in effect:
pc-selection-mode: t
display-time-mode: t
tooltip-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent messages:
Loading rmailout...done
Loading sendmail...done
Loading mailalias...done
Loading supercite...done
Loading delsel...done
Loading pc-select...done
Counting messages...done
(No new mail has arrived)
0 new messages read
Computing summary lines...done
Some time between 23.0.60 and 23.1, a minor annoyance was introduced into
rmail. When case-fold-search is nil, the dates in the rmail summary are
all rendered as "??????".
This is because of the regular expression in rmailsum.el at line 529. A
string such as "May" doesn't match the regular expression:
[adfjmnos][acepou][bcglnprtvy]
because the capital letter doesn't match when case-fold-search is nil.
The easy work-around is to turn on case-fold-search, but it would be nice
to fix it properly, so that rmail works no matter what the user-set value
is. It may also be useful to do a quick scan of the .el files to see if
there are other cases where a nil value of case-fold-search might break
some modes or behaviours.
--
Christopher Neufeld
Home page: http://www.cneufeld.ca/neufeld
"Don't edit reality for the sake of simplicity"
[-- Attachment #3: Type: message/rfc822, Size: 3560 bytes --]
From: Eli Zaretskii <eliz@gnu.org>
To: emacsbugs0001@cneufeld.ca, 3987-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3987: 23.1; Rmail summary missing dates when case-fold-search is nil
Date: Sat, 01 Aug 2009 11:23:04 +0300
Message-ID: <83prbgosd3.fsf@gnu.org>
> Date: Thu, 30 Jul 2009 20:01:07 -0400
> From: Christopher Neufeld <emacsbugs0001@cneufeld.ca>
> From: Christopher Neufeld <emacsbugs0001@cneufeld.ca>
> Cc:
>
> Some time between 23.0.60 and 23.1, a minor annoyance was introduced into
> rmail. When case-fold-search is nil, the dates in the rmail summary are
> all rendered as "??????".
Fixed with this change:
2009-08-01 Eli Zaretskii <eliz@gnu.org>
* mail/rmailsum.el (rmail-header-summary): Ignore letter-case of
month names. (Bug#3987)
Index: lisp/mail/rmailsum.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/rmailsum.el,v
retrieving revision 1.179
diff -u -r1.179 rmailsum.el
--- lisp/mail/rmailsum.el 4 Apr 2009 14:21:49 -0000 1.179
+++ lisp/mail/rmailsum.el 1 Aug 2009 08:19:26 -0000
@@ -518,16 +518,19 @@
(concat (save-excursion
(if (not (re-search-forward "^Date:" nil t))
" "
- (cond ((re-search-forward "\\([^0-9:]\\)\\([0-3]?[0-9]\\)\\([- \t_]+\\)\\([adfjmnos][aceopu][bcglnprtvy]\\)"
- (line-end-position) t)
+ ;; Match month names case-insensitively
+ (cond ((let ((case-fold-search t))
+ (re-search-forward "\\([^0-9:]\\)\\([0-3]?[0-9]\\)\\([- \t_]+\\)\\([adfjmnos][aceopu][bcglnprtvy]\\)"
+ (line-end-position) t))
(format "%2d-%3s"
(string-to-number (buffer-substring
(match-beginning 2)
(match-end 2)))
(buffer-substring
(match-beginning 4) (match-end 4))))
- ((re-search-forward "\\([^a-z]\\)\\([adfjmnos][acepou][bcglnprtvy]\\)\\([-a-z \t_]*\\)\\([0-9][0-9]?\\)"
- (line-end-position) t)
+ ((let ((case-fold-search t))
+ (re-search-forward "\\([^a-z]\\)\\([adfjmnos][acepou][bcglnprtvy]\\)\\([-a-z \t_]*\\)\\([0-9][0-9]?\\)"
+ (line-end-position) t))
(format "%2d-%3s"
(string-to-number (buffer-substring
(match-beginning 4)
^ permalink raw reply [flat|nested] 3+ messages in thread