unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: rcopley@gmail.com, 37852@debbugs.gnu.org
Subject: bug#37852: Build failure on MSYS2 (undefined reference to _chk functions)
Date: Tue, 22 Oct 2019 21:51:00 +0300	[thread overview]
Message-ID: <83o8y8zka3.fsf@gnu.org> (raw)
In-Reply-To: <e687e358-834e-eced-5a34-03c177e621e2@cs.ucla.edu> (message from Paul Eggert on Tue, 22 Oct 2019 11:27:48 -0700)

> Cc: 37852@debbugs.gnu.org, rcopley@gmail.com
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 22 Oct 2019 11:27:48 -0700
> 
> > Should we perhaps test for -lssp, and if it is found, add it to the
> > link command when we define _FORTIFY_SOURCE?
> 
> If this is done only on MSYS2 platforms, and if -lssp is used only when 
> it causes otherwise-failing programs to work, then it should be OK. I 
> wouldn't do it elsewhere because on Fedora at any rate, -lssp used to be 
> trouble and was best avoided.

Right.

> It vaguely sounds like MSYS2 is trailing Fedora and so is experiencing 
> problems Fedora had a few years ago (see, e.g., 
> <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-4973>).

I actually think it's a bug in MSYS2, and hope they will fix it soon.
So perhaps we should just wait and see if the current situation, after
your patch, is good enough.

Thanks.





  reply	other threads:[~2019-10-22 18:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 12:28 bug#37852: Build failure on MSYS2 (undefined reference to _chk functions) Richard Copley
2019-10-21 13:07 ` Eli Zaretskii
2019-10-21 13:17   ` Richard Copley
2019-10-21 13:31     ` Eli Zaretskii
2019-10-21 14:04       ` Richard Copley
2019-10-21 16:01         ` Eli Zaretskii
2019-10-21 16:05       ` Andy Moreton
2019-10-21 16:36         ` Eli Zaretskii
2019-10-21 16:55           ` Eli Zaretskii
2019-10-22  0:40 ` Paul Eggert
2019-10-22  2:37   ` Eli Zaretskii
2019-10-22 18:27     ` Paul Eggert
2019-10-22 18:51       ` Eli Zaretskii [this message]
2019-10-23 21:29         ` Richard Copley
2019-10-24 13:50           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o8y8zka3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37852@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=rcopley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).