From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 56423@debbugs.gnu.org
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Date: Thu, 07 Jul 2022 08:35:20 +0300 [thread overview]
Message-ID: <83o7y15vtz.fsf@gnu.org> (raw)
In-Reply-To: <87mtdmyrp4.fsf@web.de> (message from Michael Heerdegen on Wed, 06 Jul 2022 21:19:35 +0200)
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Date: Wed, 06 Jul 2022 21:19:35 +0200
>
> diff --git a/lisp/wdired.el b/lisp/wdired.el
> index a5858ed190..7c8969431f 100644
> --- a/lisp/wdired.el
> +++ b/lisp/wdired.el
> @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode
> (add-hook 'before-change-functions #'wdired--before-change-fn nil t)
> (add-hook 'after-change-functions #'wdired--restore-properties nil t)
> (setq major-mode 'wdired-mode)
> + (setq font-lock-major-mode 'wdired-mode)
> (setq mode-name "Editable Dired")
> (add-function :override (local 'revert-buffer-function) #'wdired-revert)
> (set-buffer-modified-p nil)
> @@ -457,6 +458,7 @@ wdired-change-to-dired-mode
> (force-mode-line-update)
> (setq buffer-read-only t)
> (setq major-mode 'dired-mode)
> + (setq font-lock-major-mode 'dired-mode)
> (setq mode-name "Dired")
> (dired-advertise)
> (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t)
Don't we need to make sure font-lock-major-mode is restored no matter
how wdired is exited, whether normally or abnormally?
I'm not too familiar with wdired, so apologies if what I said makes no
sense.
next prev parent reply other threads:[~2022-07-07 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 16:22 bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Michael Heerdegen
2022-07-06 18:58 ` Michael Heerdegen
2022-07-06 19:19 ` Michael Heerdegen
2022-07-07 5:35 ` Eli Zaretskii [this message]
2022-07-07 10:26 ` Michael Heerdegen
2022-07-07 10:35 ` Eli Zaretskii
2022-07-07 11:14 ` Michael Heerdegen
2022-07-07 13:29 ` Eli Zaretskii
2022-07-07 15:09 ` Michael Heerdegen
2022-07-07 15:19 ` Michael Heerdegen
2022-07-07 16:03 ` Eli Zaretskii
2022-07-08 12:04 ` Michael Heerdegen
2022-07-08 12:22 ` Eli Zaretskii
2022-07-08 12:57 ` Michael Heerdegen
2022-07-08 12:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7y15vtz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=56423@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).