From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Date: Thu, 07 Jul 2022 08:35:20 +0300 Message-ID: <83o7y15vtz.fsf@gnu.org> References: <874jzui52r.fsf@web.de> <87iloa2hlm.fsf@web.de> <87mtdmyrp4.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29098"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56423@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 07:36:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9KBR-0007Lj-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 07:36:13 +0200 Original-Received: from localhost ([::1]:45828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9KBP-0006ML-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 01:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9KBG-0006MC-Ro for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 01:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9KBG-000458-JK for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 01:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9KBG-0005FS-GO for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56423 X-GNU-PR-Package: emacs Original-Received: via spool by 56423-submit@debbugs.gnu.org id=B56423.165717213620137 (code B ref 56423); Thu, 07 Jul 2022 05:36:02 +0000 Original-Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 05:35:36 +0000 Original-Received: from localhost ([127.0.0.1]:55510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9KAp-0005Ej-TR for submit@debbugs.gnu.org; Thu, 07 Jul 2022 01:35:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9KAm-0005EV-IZ for 56423@debbugs.gnu.org; Thu, 07 Jul 2022 01:35:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9KAh-0002af-1R; Thu, 07 Jul 2022 01:35:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nZ0CcKD0+hEWO3dR5OgdAhOMOvOjza+WYdm0pO4hhO0=; b=qoKN0L7KK8Xm eA92PZZ4c8ldUDP0NUNV5tSyTBjXDyCindYf+z85R/vYH/PJJaYd7PrrOkA1e6LqmZAxyYE+qC+Rm Ot8EvX9D5QuOq/lZCElYNxtcMj0/TWXCQlHdyWwDjvuI9cC6MdN//O3JP+X1bkNnYYyPtIv73aYYO rF/Kab8IOvPVaeKnH7VOc3TSuCL6m2jU6kCjU/hqjkibt4AYDzvHKvnGGdOdYCHfBGXSwQT5ugY2b 3VWj8nXZgynx6G62m7NS9Ubl/RA++gOJvowvwnsIfHIkjaQ3l1Bz/oqS75PldwYRtjyXyRDZNpK2o WcuHMF/L7uZYFpbVM/p7SQ==; Original-Received: from [87.69.77.57] (port=2891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9KAe-00059P-LB; Thu, 07 Jul 2022 01:35:26 -0400 In-Reply-To: <87mtdmyrp4.fsf@web.de> (message from Michael Heerdegen on Wed, 06 Jul 2022 21:19:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236314 Archived-At: > From: Michael Heerdegen > Date: Wed, 06 Jul 2022 21:19:35 +0200 > > diff --git a/lisp/wdired.el b/lisp/wdired.el > index a5858ed190..7c8969431f 100644 > --- a/lisp/wdired.el > +++ b/lisp/wdired.el > @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode > (add-hook 'before-change-functions #'wdired--before-change-fn nil t) > (add-hook 'after-change-functions #'wdired--restore-properties nil t) > (setq major-mode 'wdired-mode) > + (setq font-lock-major-mode 'wdired-mode) > (setq mode-name "Editable Dired") > (add-function :override (local 'revert-buffer-function) #'wdired-revert) > (set-buffer-modified-p nil) > @@ -457,6 +458,7 @@ wdired-change-to-dired-mode > (force-mode-line-update) > (setq buffer-read-only t) > (setq major-mode 'dired-mode) > + (setq font-lock-major-mode 'dired-mode) > (setq mode-name "Dired") > (dired-advertise) > (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t) Don't we need to make sure font-lock-major-mode is restored no matter how wdired is exited, whether normally or abnormally? I'm not too familiar with wdired, so apologies if what I said makes no sense.