bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Augusto Stoffel]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Tags: patch

I wasn't aware of the variable cursor-in-echo-area when I originally
wrote this function, but it's a much less drastic measure than setting
inhibit-redisplay.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-isearch.el-minibuffer-lazy-highlight-setup-Use-.patch --]
[-- Type: text/patch, Size: 920 bytes --]

From 68fd9e85dc56ada87dea647d6b71dbf9ecde7391 Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Sat, 18 Feb 2023 12:26:54 +0100
Subject: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use
 cursor-in-echo-area

---
 lisp/isearch.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index bb46c89ae20..14b8a259ea4 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -4466,7 +4466,7 @@ minibuffer-lazy-highlight-setup
                 (lazy-highlight-cleanup))))
       (fset after-change
             (lambda (_beg _end _len)
-              (let ((inhibit-redisplay t) ;; Avoid cursor flickering
+              (let ((cursor-in-echo-area t) ;; Avoid cursor flickering
                     (string (minibuffer-contents)))
                 (with-minibuffer-selected-window
                   (let* ((isearch-forward t)
-- 
2.39.2

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Juri Linkov]

> I wasn't aware of the variable cursor-in-echo-area when I originally
> wrote this function, but it's a much less drastic measure than setting
> inhibit-redisplay.

I don't know if Eli will allow this to the emacs-29 branch.

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Augusto Stoffel]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

On Sat, Feb 18, 2023, 19:50 Juri Linkov <juri@linkov.net> wrote:

> > I wasn't aware of the variable cursor-in-echo-area when I originally
> > wrote this function, but it's a much less drastic measure than setting
> > inhibit-redisplay.
>
> I don't know if Eli will allow this to the emacs-29 branch.
>

I think it's okay to leave it for Emacs 30.

>

[-- Attachment #2: Type: text/html, Size: 867 bytes --]

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Eli Zaretskii]

> Cc: 61601@debbugs.gnu.org
> From: Juri Linkov <juri@linkov.net>
> Date: Sat, 18 Feb 2023 20:44:40 +0200
> 
> > I wasn't aware of the variable cursor-in-echo-area when I originally
> > wrote this function, but it's a much less drastic measure than setting
> > inhibit-redisplay.
> 
> I don't know if Eli will allow this to the emacs-29 branch.

Can you explain how the old and the new code prevent "flickering" in
that place?

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Augusto Stoffel]

On Sat, 18 Feb 2023 at 21:18, Eli Zaretskii wrote:

>> Cc: 61601@debbugs.gnu.org
>> From: Juri Linkov <juri@linkov.net>
>> Date: Sat, 18 Feb 2023 20:44:40 +0200
>> 
>> > I wasn't aware of the variable cursor-in-echo-area when I originally
>> > wrote this function, but it's a much less drastic measure than setting
>> > inhibit-redisplay.
>> 
>> I don't know if Eli will allow this to the emacs-29 branch.
>
> Can you explain how the old and the new code prevent "flickering" in
> that place?

The flickering happens because the cursor briefly moves from the
minibuffer to the minibuffer selected window when the lazy highlighting
is done (e.g. after typing a character in the C-M-% regexp query).

The previous solution was to inhibit redisplay during that brief period.
The new and better solution is to just set cursor-in-echo-area, which
does exactly what we want to happen.

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Drew Adams]

> The flickering happens because the cursor briefly moves from the
> minibuffer to the minibuffer selected window when the lazy highlighting
> is done (e.g. after typing a character in the C-M-% regexp query).

FWIW -
No such problems existed before Isearch started 
using the minibuffer instead of the echo area.

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Eli Zaretskii]

> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: Juri Linkov <juri@linkov.net>,  61601@debbugs.gnu.org
> Date: Sat, 18 Feb 2023 22:40:13 +0100
> 
> On Sat, 18 Feb 2023 at 21:18, Eli Zaretskii wrote:
> 
> > Can you explain how the old and the new code prevent "flickering" in
> > that place?
> 
> The flickering happens because the cursor briefly moves from the
> minibuffer to the minibuffer selected window when the lazy highlighting
> is done (e.g. after typing a character in the C-M-% regexp query).
> 
> The previous solution was to inhibit redisplay during that brief period.
> The new and better solution is to just set cursor-in-echo-area, which
> does exactly what we want to happen.

OK, thanks.  It's fine with me to install this on emacs-29.

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Augusto Stoffel]

On Sat, 18 Feb 2023 at 22:43, Drew Adams wrote:

>> The flickering happens because the cursor briefly moves from the
>> minibuffer to the minibuffer selected window when the lazy highlighting
>> is done (e.g. after typing a character in the C-M-% regexp query).
>
> FWIW -
> No such problems existed before Isearch started 
> using the minibuffer instead of the echo area.

AFAICT C-M-% always used the minibuffer to read a regular expression.
This has nothing to do with Isearch per se.

Also, in isearch I still see cursor flickering when I type fast enough.
But since I normally use isearch-mb, which is not affected by this, I
can't describe the problem in more detail.

bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area

[Drew Adams]

> > No such problems existed before Isearch started
> > using the minibuffer instead of the echo area.
> 
> AFAICT C-M-% always used the minibuffer to read a regular expression.
> This has nothing to do with Isearch per se.

If this is only about C-M-% reading a regexp
then OK, and I apologize for not having read
more of the thread.

C-M-%'s reading of a regexp is an all-at-once,
one time reading that uses the minibuffer.

That reading has nothing to do with Isearch's
reading of keys you type, for incremental
input and editing of the search pattern.  

_If_ this is about Isearch's incremental
handling of a search pattern, then maybe my
comment is relevant.  Apart from `M-e', since
Day One Isearch always read input directly,
not using the minibuffer.  It displayed what
you typed in the echo area, giving somewhat
the (mistaken) impression that input was in
the minibuffer.