bug#62935: 29.0.90; icomplete-vertical-mode misses add-file-local-variable alternative

bug#62935: 29.0.90; icomplete-vertical-mode misses add-file-local-variable alternative

[Van Ly]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]


The icomplete-vertical-mode does not list buffer-save-without-query as an option to add-file-local-variable after the input prefix buffer- .

Steps to reproduce
 - emacs -Q
 - switch to buffer bbb, C-x b bbb RET
 - enable completion mode, M-x icomplete-vertical-mode
 - add file local variable, M-x add-file-local-variable abbreviated by
   = M-x add-fi C-j
   = buffer- [does not list completion buffer-save-without-query]
   = alternatives listed are
     - buffer-read-only
     - buffer-offer-save

Expected behavior
 - completion mode lists buffer-save-without-query
   = example of desired completion listing
     - buffer-read-only
     - buffer-offer-save
     - buffer-save-without-query

Unexpected behavior
 - completion mode lists two alternatives without desired option
   = observed completion listing
     - buffer-read-only
     - buffer-offer-save


[-- Attachment #2: bug gnu emacs report --]
[-- Type: application/octet-stream, Size: 2908 bytes --]

In GNU Emacs 29.0.90 (build 1, aarch64-unknown-linux-gnu, GTK+ Version
 3.24.24, cairo version 1.16.0) of 2023-04-12 built on x23
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG
LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM
XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: C.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  icomplete-vertical-mode: t
  icomplete-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
thingatpt help-fns radix-tree help-mode files-x cus-start cus-load
icomplete cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 49698 4488)
 (symbols 48 6441 0)
 (strings 32 16364 2360)
 (string-bytes 1 441227)
 (vectors 16 10080)
 (vector-slots 8 155531 9766)
 (floats 8 23 23)
 (intervals 56 336 0)
 (buffers 984 12))

bug#62935: 29.0.90; icomplete-vertical-mode misses add-file-local-variable alternative

[Eli Zaretskii]

> Date: Tue, 18 Apr 2023 14:53:54 GMT
> From: Van Ly <van.ly@sdf.org>
> 
> The icomplete-vertical-mode does not list buffer-save-without-query as an option to add-file-local-variable after the input prefix buffer- .
> 
> Steps to reproduce
>  - emacs -Q
>  - switch to buffer bbb, C-x b bbb RET
>  - enable completion mode, M-x icomplete-vertical-mode
>  - add file local variable, M-x add-file-local-variable abbreviated by
>    = M-x add-fi C-j
>    = buffer- [does not list completion buffer-save-without-query]
>    = alternatives listed are
>      - buffer-read-only
>      - buffer-offer-save
> 
> Expected behavior
>  - completion mode lists buffer-save-without-query
>    = example of desired completion listing
>      - buffer-read-only
>      - buffer-offer-save
>      - buffer-save-without-query
> 
> Unexpected behavior
>  - completion mode lists two alternatives without desired option
>    = observed completion listing
>      - buffer-read-only
>      - buffer-offer-save

add-file-local-variable completes only on variables that are safe as
local variables, and buffer-save-without-query is not.  So you need to
type its name completely.

This is not a bug.

bug#62935: 29.0.90; icomplete-vertical-mode misses add-file-local-variable alternative

[Van Ly]

> Date: Tue, 18 Apr 2023 18:53:01 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 62935@debbugs.gnu.org
> 
> 
> add-file-local-variable completes only on variables that are safe as
> local variables, and buffer-save-without-query is not.  So you need to
> type its name completely.
> 

I see why.  Maybe unsafe options can allow an override to appear in
grey faded font.  There could be an explainer dialogue for what is unsafe.

I use buffer-save-without-query on scratch files.

bug#62935: 29.0.90; icomplete-vertical-mode misses add-file-local-variable alternative

[Stefan Kangas]

tags 62935 notabug wontfix
close 62935
thanks

Van Ly <van.ly@sdf.org> writes:

>> Date: Tue, 18 Apr 2023 18:53:01 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: 62935@debbugs.gnu.org
>>
>>
>> add-file-local-variable completes only on variables that are safe as
>> local variables, and buffer-save-without-query is not.  So you need to
>> type its name completely.
>>
>
> I see why.  Maybe unsafe options can allow an override to appear in
> grey faded font.  There could be an explainer dialogue for what is unsafe.
>
> I use buffer-save-without-query on scratch files.

I tend to agree with Eli here, and I don't think we want to add unsafe
options there, as it will be too confusing.  So I'm closing this bug.