From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: luangruo@yahoo.com, 59242@debbugs.gnu.org, lg.zevlg@gmail.com
Subject: bug#59242: 29.0.50; Poor quality for WebP images
Date: Mon, 14 Aug 2023 05:33:09 +0300 [thread overview]
Message-ID: <83o7jabbfe.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkkxg87fMpSaDcOr4PmuJ9eU5HqkmWeT2gXYKyxmwmLog@mail.gmail.com> (message from Stefan Kangas on Mon, 14 Aug 2023 02:11:56 +0200)
> Cc: 59242@debbugs.gnu.org, Evgeny Zajcev <lg.zevlg@gmail.com>
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Mon, 14 Aug 2023 02:11:56 +0200
>
> Po Lu <luangruo@yahoo.com> writes:
>
> > > Evgeny Zajcev <lg.zevlg@gmail.com> writes:
> >
> > > Looks like partial transparency is incorrectly applied for webp images.
>
> Thanks for the bug report.
>
> > Stefan, I see the following code in image.c:
> [...]
> > So if the webp library does not blend itself, I think we will have to do
> > that for it. Am I missing anything here?
>
> Yes, the old code was not right. The attached patch should add proper
> alpha blending for webp images. I have tested it with the example
> images here: https://developers.google.com/speed/webp/gallery2
>
> Evgeny, could you please test this patch and report back? It should
> apply cleanly both against master and emacs-29.
Thanks, but please install this on master, not on the emacs-29 branch,
even if this patch does work. It's too late for such changes on the
release branch.
next prev parent reply other threads:[~2023-08-14 2:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 8:48 bug#59242: 29.0.50; Poor quality for WebP images Evgeny Zajcev
2022-11-13 9:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 0:11 ` Stefan Kangas
2023-08-14 2:33 ` Eli Zaretskii [this message]
2023-08-14 7:08 ` Stefan Kangas
2023-08-25 18:28 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7jabbfe.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59242@debbugs.gnu.org \
--cc=lg.zevlg@gmail.com \
--cc=luangruo@yahoo.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).