From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59242: 29.0.50; Poor quality for WebP images Date: Mon, 14 Aug 2023 05:33:09 +0300 Message-ID: <83o7jabbfe.fsf@gnu.org> References: <877czzkx3d.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 59242@debbugs.gnu.org, lg.zevlg@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 14 04:34:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVNPL-00063M-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Aug 2023 04:34:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVNPA-0004gN-Pd; Sun, 13 Aug 2023 22:34:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVNP9-0004fy-0q for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 22:34:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVNP8-0005hV-No for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 22:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVNP8-0008BI-H8 for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2023 22:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2023 02:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59242-submit@debbugs.gnu.org id=B59242.169198039831375 (code B ref 59242); Mon, 14 Aug 2023 02:34:02 +0000 Original-Received: (at 59242) by debbugs.gnu.org; 14 Aug 2023 02:33:18 +0000 Original-Received: from localhost ([127.0.0.1]:60513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVNOQ-00089y-GL for submit@debbugs.gnu.org; Sun, 13 Aug 2023 22:33:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVNOO-00089g-Gi for 59242@debbugs.gnu.org; Sun, 13 Aug 2023 22:33:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVNOI-0005Vk-VX; Sun, 13 Aug 2023 22:33:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GHH5QyZpmzGDAOXgnzaj9zwc+skqillQbJk8vdp59Po=; b=V7D9ZRVtCi5M N/wiO0Bm3LAFb9R+Zlek4Yaw8Yqyw2tFuVUSkFMocX0i2sR08yWDyedlaLGmyqfeQ1/mR4EPEzmtn ovz8+bLPnhPtzGjbgOQp7N7Bo1HuEEhUKFL+m9NUHdphdgX/4e1+1RIL1CH0ooTkRKe/bz/fgoCqf DJfG0Sty4u4KJxyKSkMgWDScjnn5yEs4+56WBkaaPAQiGoK+9FJVEsVyLmYLVEg8p5doqpTUB6fBI 1/vQqy03t7A885bxqytairFLjayLYiMVOgpaL14ofnytxvuqQtuzneDDhGynAqivzZHWoyczDXzNA p2LZ+hV2cnxAI//4Ol8xaw==; In-Reply-To: (message from Stefan Kangas on Mon, 14 Aug 2023 02:11:56 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267391 Archived-At: > Cc: 59242@debbugs.gnu.org, Evgeny Zajcev > From: Stefan Kangas > Date: Mon, 14 Aug 2023 02:11:56 +0200 > > Po Lu writes: > > > > Evgeny Zajcev writes: > > > > > Looks like partial transparency is incorrectly applied for webp images. > > Thanks for the bug report. > > > Stefan, I see the following code in image.c: > [...] > > So if the webp library does not blend itself, I think we will have to do > > that for it. Am I missing anything here? > > Yes, the old code was not right. The attached patch should add proper > alpha blending for webp images. I have tested it with the example > images here: https://developers.google.com/speed/webp/gallery2 > > Evgeny, could you please test this patch and report back? It should > apply cleanly both against master and emacs-29. Thanks, but please install this on master, not on the emacs-29 branch, even if this patch does work. It's too late for such changes on the release branch.