From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 13539@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#13539: Use fdopendir, fstatat and readlinkat, for efficiency.
Date: Wed, 30 Jan 2013 22:24:14 +0200 [thread overview]
Message-ID: <83mwvqh11t.fsf@gnu.org> (raw)
In-Reply-To: <jwvmwvqblj5.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>, 13539@debbugs.gnu.org
> Date: Wed, 30 Jan 2013 14:24:06 -0500
>
> >> perhaps a further optimization would be to avoid the call to
> >> file_name_completion_stat if completion-ignored-extensions is devoid
> >> of elements that end in a slash.
> > Yes, something like that might make sense.
>
> Maybe. But maybe not. The default value of
> completion-ignored-extensions includes elements that end in a slash, and
> I think fairly few uses of try-completion rebind it to something else.
I agree. It just sounds excessive to invoke lstat/stat _twice_ just
to support this one feature.
Perhaps at least systems that have d_type could avoid one of these 2
calls. (d_type can easily be added to the Windows emulation.)
prev parent reply other threads:[~2013-01-30 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 8:26 bug#13539: Use fdopendir, fstatat and readlinkat, for efficiency Paul Eggert
2013-01-24 17:28 ` Eli Zaretskii
2013-01-28 8:34 ` Paul Eggert
2013-01-28 14:37 ` Eli Zaretskii
2013-01-30 0:56 ` Paul Eggert
2013-01-30 17:27 ` Eli Zaretskii
2013-02-01 6:42 ` Paul Eggert
2013-01-30 19:24 ` Stefan Monnier
2013-01-30 20:24 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mwvqh11t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13539@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).