From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13539: Use fdopendir, fstatat and readlinkat, for efficiency. Date: Wed, 30 Jan 2013 22:24:14 +0200 Message-ID: <83mwvqh11t.fsf@gnu.org> References: <5100F04A.1020603@cs.ucla.edu> <83vcamlcce.fsf@gnu.org> <51063829.3020500@cs.ucla.edu> <83obg9idab.fsf@gnu.org> <51086FC5.20401@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1359577532 30840 80.91.229.3 (30 Jan 2013 20:25:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Jan 2013 20:25:32 +0000 (UTC) Cc: 13539@debbugs.gnu.org, eggert@cs.ucla.edu To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 30 21:25:51 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U0eE6-00023B-MP for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jan 2013 21:25:46 +0100 Original-Received: from localhost ([::1]:34603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0eDo-0004kq-Bw for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jan 2013 15:25:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0eDl-0004kk-Cn for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 15:25:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0eDk-0001VO-CP for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 15:25:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0eDk-0001VJ-91 for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 15:25:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U0eEL-00033T-NK for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 15:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jan 2013 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13539-submit@debbugs.gnu.org id=B13539.135957751411679 (code B ref 13539); Wed, 30 Jan 2013 20:26:01 +0000 Original-Received: (at 13539) by debbugs.gnu.org; 30 Jan 2013 20:25:14 +0000 Original-Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0eDZ-00032K-J8 for submit@debbugs.gnu.org; Wed, 30 Jan 2013 15:25:13 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:43002) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0eDV-000329-Np for 13539@debbugs.gnu.org; Wed, 30 Jan 2013 15:25:11 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MHG00100G48ZG00@a-mtaout20.012.net.il> for 13539@debbugs.gnu.org; Wed, 30 Jan 2013 22:24:29 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHG002AAGOR2M20@a-mtaout20.012.net.il>; Wed, 30 Jan 2013 22:24:27 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70499 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 13539@debbugs.gnu.org > Date: Wed, 30 Jan 2013 14:24:06 -0500 > > >> perhaps a further optimization would be to avoid the call to > >> file_name_completion_stat if completion-ignored-extensions is devoid > >> of elements that end in a slash. > > Yes, something like that might make sense. > > Maybe. But maybe not. The default value of > completion-ignored-extensions includes elements that end in a slash, and > I think fairly few uses of try-completion rebind it to something else. I agree. It just sounds excessive to invoke lstat/stat _twice_ just to support this one feature. Perhaps at least systems that have d_type could avoid one of these 2 calls. (d_type can easily be added to the Windows emulation.)