* bug#34068: 26.1; next-error does not go to correct column for grep
@ 2019-01-14 12:43 Trevor Spiteri
2019-01-19 7:54 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Trevor Spiteri @ 2019-01-14 12:43 UTC (permalink / raw)
To: 34068
This is a regression from 25 which has the correct behaviour.
emacs -Q
C-x C-f /tmp/hello
Hello
C-x C-s
M-x grep
C-a C-k grep --color -nH --null -e ll /tmp/hello
C-x `
This puts the mark in column 0, not in column 2, even though "ll" is
highlighted in the *grep* buffer.
This is a regression in 26.1, it used to work in 25.
To fix it in my local copy, I edit grep-regexp-alist in grep.el. There
are two instances of 'grep-match-face which I replaced with an unquoted
grep-match-face.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#34068: 26.1; next-error does not go to correct column for grep
2019-01-14 12:43 bug#34068: 26.1; next-error does not go to correct column for grep Trevor Spiteri
@ 2019-01-19 7:54 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2019-01-19 7:54 UTC (permalink / raw)
To: Trevor Spiteri; +Cc: 34068-done
> From: Trevor Spiteri <tspiteri@ieee.org>
> Date: Mon, 14 Jan 2019 13:43:21 +0100
>
> This is a regression from 25 which has the correct behaviour.
>
> emacs -Q
> C-x C-f /tmp/hello
> Hello
> C-x C-s
> M-x grep
> C-a C-k grep --color -nH --null -e ll /tmp/hello
> C-x `
>
> This puts the mark in column 0, not in column 2, even though "ll" is
> highlighted in the *grep* buffer.
>
> This is a regression in 26.1, it used to work in 25.
>
> To fix it in my local copy, I edit grep-regexp-alist in grep.el. There
> are two instances of 'grep-match-face which I replaced with an unquoted
> grep-match-face.
Thanks, I installed your proposed change, and I'm closing the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-19 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-14 12:43 bug#34068: 26.1; next-error does not go to correct column for grep Trevor Spiteri
2019-01-19 7:54 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).