* bug#64451: 30.0.50; split-root-window-right ignores side windows
@ 2023-07-03 23:38 Aaron Jensen
2023-07-06 7:52 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Aaron Jensen @ 2023-07-03 23:38 UTC (permalink / raw)
To: 64451
(display-buffer "*scratch*" '(display-buffer-in-side-window . ((side . right))))
M-x split-root-window-right
I would expect the new window to be to the left of the side window (I
know this is counter-intuitive to splititng the root window, but it's
also intuitive given the nature of side windows...)
I don't know if this is intentional. I also don't know if it's a
regression as it's not behavior I remember seeing until fairly recently.
In GNU Emacs 30.0.50 (build 51, aarch64-apple-darwin22.5.0, NS
appkit-2299.60 Version 13.4.1 (Build 22F82)) of 2023-06-25 built on
Aarons-Laptop.local
Repository revision: e85ebb3d82466c5838e9c6836e6d8b5c8d0a7c33
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description: macOS 13.4.1
Configured using:
'configure --with-ns --with-native-compilation --with-modules
--without-dbus --without-webp --disable-ns-self-contained'
Configured features:
ACL GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS
PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER XIM
ZLIB
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-07-03 23:38 bug#64451: 30.0.50; split-root-window-right ignores side windows Aaron Jensen
@ 2023-07-06 7:52 ` Eli Zaretskii
2023-07-07 13:57 ` martin rudalics
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-07-06 7:52 UTC (permalink / raw)
To: Aaron Jensen, martin rudalics; +Cc: 64451
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Mon, 03 Jul 2023 19:38:01 -0400
>
>
> (display-buffer "*scratch*" '(display-buffer-in-side-window . ((side . right))))
> M-x split-root-window-right
>
> I would expect the new window to be to the left of the side window (I
> know this is counter-intuitive to splititng the root window, but it's
> also intuitive given the nature of side windows...)
>
> I don't know if this is intentional. I also don't know if it's a
> regression as it's not behavior I remember seeing until fairly recently.
Martin, any comments?
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-07-06 7:52 ` Eli Zaretskii
@ 2023-07-07 13:57 ` martin rudalics
2023-07-08 9:09 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2023-07-07 13:57 UTC (permalink / raw)
To: Eli Zaretskii, Aaron Jensen; +Cc: 64451
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
>> (display-buffer "*scratch*" '(display-buffer-in-side-window . ((side . right))))
>> M-x split-root-window-right
>>
>> I would expect the new window to be to the left of the side window (I
>> know this is counter-intuitive to splititng the root window, but it's
>> also intuitive given the nature of side windows...)
>>
>> I don't know if this is intentional. I also don't know if it's a
>> regression as it's not behavior I remember seeing until fairly recently.
>
> Martin, any comments?
There are two bugs. The first one is that splitting a root window with
side windows is always an error unless a new side window on another side
should be made. This should be fixed by the attached patch.
The second bug is that the 'split-root-window-...' functions probably
should split 'window-main-window' on that frame instead. I'd rather
leave the fix for that to the people who wrote those functions.
martin
[-- Attachment #2: split-window.diff --]
[-- Type: text/x-patch, Size: 691 bytes --]
diff --git a/lisp/window.el b/lisp/window.el
index 16f16a75418..0ddd04b0696 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -5434,6 +5434,10 @@ split-window
(setq atom-root (window-atom-root window))
(not (eq atom-root window)))
(throw 'done (split-window atom-root size side pixelwise)))
+ ((and (eq window (frame-root-window frame))
+ (not (eq window-combination-resize 'side))
+ (window-with-parameter 'window-side nil frame))
+ (error "Cannot split root window with side windows"))
;; If WINDOW is a side window or its first or last child is a
;; side window, throw an error unless `window-combination-resize'
;; equals 'side.
^ permalink raw reply related [flat|nested] 9+ messages in thread* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-07-07 13:57 ` martin rudalics
@ 2023-07-08 9:09 ` Eli Zaretskii
2023-07-15 7:51 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-07-08 9:09 UTC (permalink / raw)
To: martin rudalics, Hugo Heagren; +Cc: 64451, aaronjensen
> Date: Fri, 7 Jul 2023 15:57:12 +0200
> Cc: 64451@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
>
> There are two bugs. The first one is that splitting a root window with
> side windows is always an error unless a new side window on another side
> should be made. This should be fixed by the attached patch.
>
> The second bug is that the 'split-root-window-...' functions probably
> should split 'window-main-window' on that frame instead. I'd rather
> leave the fix for that to the people who wrote those functions.
Hugo, I guess this means you? Could you please look into this issue?
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-07-08 9:09 ` Eli Zaretskii
@ 2023-07-15 7:51 ` Eli Zaretskii
2023-07-16 16:54 ` hugo
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-07-15 7:51 UTC (permalink / raw)
To: hugo; +Cc: rudalics, 64451, aaronjensen
Ping! Hugo, could you please take a look?
> Cc: 64451@debbugs.gnu.org, aaronjensen@gmail.com
> Date: Sat, 08 Jul 2023 12:09:32 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Fri, 7 Jul 2023 15:57:12 +0200
> > Cc: 64451@debbugs.gnu.org
> > From: martin rudalics <rudalics@gmx.at>
> >
> > There are two bugs. The first one is that splitting a root window with
> > side windows is always an error unless a new side window on another side
> > should be made. This should be fixed by the attached patch.
> >
> > The second bug is that the 'split-root-window-...' functions probably
> > should split 'window-main-window' on that frame instead. I'd rather
> > leave the fix for that to the people who wrote those functions.
>
> Hugo, I guess this means you? Could you please look into this issue?
>
> Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-07-15 7:51 ` Eli Zaretskii
@ 2023-07-16 16:54 ` hugo
2023-08-03 7:40 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: hugo @ 2023-07-16 16:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: rudalics, 64451, aaronjensen
On 2023-07-15 08:51, Eli Zaretskii wrote:
> Ping! Hugo, could you please take a look?
> ...
>> Hugo, I guess this means you? Could you please look into this issue?
>>
>> Thanks.
Sorry, I've been on holiday and only just got back.
I'll take a look, and update once I have something useful to say.
Hugo
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-07-16 16:54 ` hugo
@ 2023-08-03 7:40 ` Eli Zaretskii
2023-08-12 6:46 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-08-03 7:40 UTC (permalink / raw)
To: hugo; +Cc: rudalics, 64451, aaronjensen
Ping! Any progress with this?
> Date: Sun, 16 Jul 2023 17:54:12 +0100
> From: hugo@heagren.com
> Cc: rudalics@gmx.at, 64451@debbugs.gnu.org, aaronjensen@gmail.com
>
> On 2023-07-15 08:51, Eli Zaretskii wrote:
> > Ping! Hugo, could you please take a look?
> > ...
> >> Hugo, I guess this means you? Could you please look into this issue?
> >>
> >> Thanks.
>
> Sorry, I've been on holiday and only just got back.
>
> I'll take a look, and update once I have something useful to say.
>
> Hugo
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-08-03 7:40 ` Eli Zaretskii
@ 2023-08-12 6:46 ` Eli Zaretskii
2023-08-19 8:20 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2023-08-12 6:46 UTC (permalink / raw)
To: hugo; +Cc: rudalics, 64451, aaronjensen
Ping! Ping!
> Cc: rudalics@gmx.at, 64451@debbugs.gnu.org, aaronjensen@gmail.com
> Date: Thu, 03 Aug 2023 10:40:28 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Ping! Any progress with this?
>
> > Date: Sun, 16 Jul 2023 17:54:12 +0100
> > From: hugo@heagren.com
> > Cc: rudalics@gmx.at, 64451@debbugs.gnu.org, aaronjensen@gmail.com
> >
> > On 2023-07-15 08:51, Eli Zaretskii wrote:
> > > Ping! Hugo, could you please take a look?
> > > ...
> > >> Hugo, I guess this means you? Could you please look into this issue?
> > >>
> > >> Thanks.
> >
> > Sorry, I've been on holiday and only just got back.
> >
> > I'll take a look, and update once I have something useful to say.
> >
> > Hugo
> >
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64451: 30.0.50; split-root-window-right ignores side windows
2023-08-12 6:46 ` Eli Zaretskii
@ 2023-08-19 8:20 ` Eli Zaretskii
0 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2023-08-19 8:20 UTC (permalink / raw)
To: hugo; +Cc: rudalics, 64451, aaronjensen
Ping! Ping! Ping! Any progress with this?
> Cc: rudalics@gmx.at, 64451@debbugs.gnu.org, aaronjensen@gmail.com
> Date: Sat, 12 Aug 2023 09:46:50 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Ping! Ping!
>
> > Cc: rudalics@gmx.at, 64451@debbugs.gnu.org, aaronjensen@gmail.com
> > Date: Thu, 03 Aug 2023 10:40:28 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > Ping! Any progress with this?
> >
> > > Date: Sun, 16 Jul 2023 17:54:12 +0100
> > > From: hugo@heagren.com
> > > Cc: rudalics@gmx.at, 64451@debbugs.gnu.org, aaronjensen@gmail.com
> > >
> > > On 2023-07-15 08:51, Eli Zaretskii wrote:
> > > > Ping! Hugo, could you please take a look?
> > > > ...
> > > >> Hugo, I guess this means you? Could you please look into this issue?
> > > >>
> > > >> Thanks.
> > >
> > > Sorry, I've been on holiday and only just got back.
> > >
> > > I'll take a look, and update once I have something useful to say.
> > >
> > > Hugo
> > >
> >
> >
> >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-08-19 8:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 23:38 bug#64451: 30.0.50; split-root-window-right ignores side windows Aaron Jensen
2023-07-06 7:52 ` Eli Zaretskii
2023-07-07 13:57 ` martin rudalics
2023-07-08 9:09 ` Eli Zaretskii
2023-07-15 7:51 ` Eli Zaretskii
2023-07-16 16:54 ` hugo
2023-08-03 7:40 ` Eli Zaretskii
2023-08-12 6:46 ` Eli Zaretskii
2023-08-19 8:20 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).