From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 14635@debbugs.gnu.org
Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes
Date: Fri, 30 Oct 2020 16:16:27 +0200 [thread overview]
Message-ID: <83lffnajes.fsf@gnu.org> (raw)
In-Reply-To: <CABczVwfpwOxw2Gv-ob_pXufD7+SUojnDKAs1vjGzUcB7k9PFtA@mail.gmail.com> (message from Mauro Aranda on Fri, 30 Oct 2020 11:03:39 -0300)
> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Fri, 30 Oct 2020 11:03:39 -0300
> Cc: Drew Adams <drew.adams@oracle.com>, 14635@debbugs.gnu.org
>
> > Doesn't customizing a face record the original value in some property
> > of the face symbol? If so, reverting the customizations should use
> > those recorded values, I think.
>
> AFAICT, it doesn't right now. I followed the recipe I gave, and then:
> (symbol-plist 'default)
> The relevant properties I see are:
> * face-defface-spec ==> ((t nil))
> which won't take us anywhere.
> * theme-face, which has the customized value for the user theme, and
> * customized-face, which again, has the customized value.
>
> But I see no immediate reason why we shouldn't start doing it, if you
> think it is OK to use that to solve this issue. My only questions are
> if it would be best to do it in Customize or in faces.el, and if we
> should only special case the default face.
I'd begin with doing this in Customize, since it is the only user of
this property.
next prev parent reply other threads:[~2020-10-30 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 9:18 bug#14635: 24.3.50; Regression in Customize: no revert changes Drew Adams
2013-06-16 10:30 ` Juanma Barranquero
2020-10-30 13:35 ` Mauro Aranda
2020-10-30 13:43 ` Eli Zaretskii
2020-10-30 14:03 ` Mauro Aranda
2020-10-30 14:16 ` Eli Zaretskii [this message]
2020-10-30 14:23 ` Mauro Aranda
2020-10-31 14:56 ` Mauro Aranda
2022-02-05 23:39 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lffnajes.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14635@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).