From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Date: Fri, 30 Oct 2020 16:16:27 +0200 Message-ID: <83lffnajes.fsf@gnu.org> References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18621"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14635@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 15:29:00 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYVOl-0004id-Q5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 15:28:59 +0100 Original-Received: from localhost ([::1]:34788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYVOk-0005BV-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 10:28:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYVDC-0000XP-L5 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYVDC-0007ud-Bn for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYVDC-0001HR-6a for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.16040674124903 (code B ref 14635); Fri, 30 Oct 2020 14:17:02 +0000 Original-Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 14:16:52 +0000 Original-Received: from localhost ([127.0.0.1]:59138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVD2-0001H1-FS for submit@debbugs.gnu.org; Fri, 30 Oct 2020 10:16:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVD0-0001Gj-VG for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 10:16:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45152) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYVCv-0007si-LP; Fri, 30 Oct 2020 10:16:45 -0400 Original-Received: from [176.228.60.248] (port=4841 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYVCu-0001pK-Ou; Fri, 30 Oct 2020 10:16:45 -0400 In-Reply-To: (message from Mauro Aranda on Fri, 30 Oct 2020 11:03:39 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192114 Archived-At: > From: Mauro Aranda > Date: Fri, 30 Oct 2020 11:03:39 -0300 > Cc: Drew Adams , 14635@debbugs.gnu.org > > > Doesn't customizing a face record the original value in some property > > of the face symbol? If so, reverting the customizations should use > > those recorded values, I think. > > AFAICT, it doesn't right now. I followed the recipe I gave, and then: > (symbol-plist 'default) > The relevant properties I see are: > * face-defface-spec ==> ((t nil)) > which won't take us anywhere. > * theme-face, which has the customized value for the user theme, and > * customized-face, which again, has the customized value. > > But I see no immediate reason why we shouldn't start doing it, if you > think it is OK to use that to solve this issue. My only questions are > if it would be best to do it in Customize or in faces.el, and if we > should only special case the default face. I'd begin with doing this in Customize, since it is the only user of this property.