From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: phil@hagelb.org, 49918@debbugs.gnu.org
Subject: bug#49918: 28.0.50; cd function expands CDPATH incorrectly
Date: Sun, 08 Aug 2021 17:32:23 +0300 [thread overview]
Message-ID: <83lf5cgg7c.fsf@gnu.org> (raw)
In-Reply-To: <87v94g5cqh.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 08 Aug 2021 14:42:46 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: phil@hagelb.org, 49918@debbugs.gnu.org
> Date: Sun, 08 Aug 2021 14:42:46 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Why does the current implementation of parse-colon-path use
> > expand-file-name? The comment says "to expand "~", but the original
> > implementation in Emacs 27 didn't do that.
>
> I should probably have written (etc) after that comment...
>
> > Bug#21454 only wanted to avoid mis-interpreting duplicate slashes in
> > the input path, but there's no need to collapse them, so I don't see
> > how the call to expand-file-name is at all necessary, and could
> > potentially change behavior in unintended ways. Am I missing
> > something?
>
> Tino's tests in files-tests-bug-21454 test explicitly for the duplicate
> slash collapsing, so I assumed that was part of the point. But I may
> well be mistaken -- feel free to adjust this some more.
Done. I don't think we should collapse slashes except the leading
one, it isn't something this function should do, and is not in its
documentation.
prev parent reply other threads:[~2021-08-08 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 1:18 bug#49918: 28.0.50; cd function expands CDPATH incorrectly Phil Hagelberg
2021-08-07 10:51 ` Lars Ingebrigtsen
2021-08-07 12:17 ` Eli Zaretskii
2021-08-07 15:50 ` Phil Hagelberg
2021-08-08 12:42 ` Lars Ingebrigtsen
2021-08-08 14:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf5cgg7c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49918@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=phil@hagelb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).