From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49918: 28.0.50; cd function expands CDPATH incorrectly Date: Sun, 08 Aug 2021 17:32:23 +0300 Message-ID: <83lf5cgg7c.fsf@gnu.org> References: <87lf5eyrvx.fsf@hagelb.org> <87wnox7ck5.fsf@gnus.org> <835ywhih4h.fsf@gnu.org> <87v94g5cqh.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phil@hagelb.org, 49918@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 08 16:33:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCjra-000825-4q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Aug 2021 16:33:18 +0200 Original-Received: from localhost ([::1]:34974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCjrY-00058B-1A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Aug 2021 10:33:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCjrK-00057v-LT for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2021 10:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mCjrK-0004el-C4 for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2021 10:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mCjrK-00054S-7d for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2021 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Aug 2021 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49918 X-GNU-PR-Package: emacs Original-Received: via spool by 49918-submit@debbugs.gnu.org id=B49918.162843315219453 (code B ref 49918); Sun, 08 Aug 2021 14:33:02 +0000 Original-Received: (at 49918) by debbugs.gnu.org; 8 Aug 2021 14:32:32 +0000 Original-Received: from localhost ([127.0.0.1]:54692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCjqq-00053h-G4 for submit@debbugs.gnu.org; Sun, 08 Aug 2021 10:32:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCjql-00053R-3l for 49918@debbugs.gnu.org; Sun, 08 Aug 2021 10:32:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36812) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCjqf-0004Ej-0E; Sun, 08 Aug 2021 10:32:21 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2004 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCjqc-00028R-Dl; Sun, 08 Aug 2021 10:32:20 -0400 In-Reply-To: <87v94g5cqh.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 08 Aug 2021 14:42:46 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211406 Archived-At: > From: Lars Ingebrigtsen > Cc: phil@hagelb.org, 49918@debbugs.gnu.org > Date: Sun, 08 Aug 2021 14:42:46 +0200 > > Eli Zaretskii writes: > > > Why does the current implementation of parse-colon-path use > > expand-file-name? The comment says "to expand "~", but the original > > implementation in Emacs 27 didn't do that. > > I should probably have written (etc) after that comment... > > > Bug#21454 only wanted to avoid mis-interpreting duplicate slashes in > > the input path, but there's no need to collapse them, so I don't see > > how the call to expand-file-name is at all necessary, and could > > potentially change behavior in unintended ways. Am I missing > > something? > > Tino's tests in files-tests-bug-21454 test explicitly for the duplicate > slash collapsing, so I assumed that was part of the point. But I may > well be mistaken -- feel free to adjust this some more. Done. I don't think we should collapse slashes except the leading one, it isn't something this function should do, and is not in its documentation.