unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: contovob@tcd.ie, f.j.wright@live.co.uk,
	francis.j.wright@gmail.com, 30529@debbugs.gnu.org
Subject: bug#30529: 26.0.91; minibuffer errors change standard-output
Date: Thu, 12 Aug 2021 18:58:31 +0300	[thread overview]
Message-ID: <83lf56d594.fsf@gnu.org> (raw)
In-Reply-To: <878s16k9zn.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu,  12 Aug 2021 16:34:20 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 12 Aug 2021 16:34:20 +0200
> Cc: f.j.wright@live.co.uk, Francis Wright <francis.j.wright@gmail.com>,
>  30529@debbugs.gnu.org
> 
> Found the culprit!  cmd_error sets standard_output to t!
> 
> The following patch fixes the reported issue (and doesn't lead to any
> regressions in the test suite), but this code has been like this
> forever, so I'm a bit leery about applying it.
> 
> And perhaps the 
> 
>   old_level = Vprint_level;
>   old_length = Vprint_length;
> 
> stuff should also be changed to specbinding?  Or do we want to avoid
> specbind here totally for some reason?  The commit for those lines just
> says:
> 
>     (cmd_error): Bind Vprint_level and Vprint_length.
> 
> I mean, we had specbind before 1995, I think?
> 
> So...  any comments/insights here?

I see no problems with the patch.  As we add calls into Lisp in more
and more places in the internals, we hit code that never imagined it
could be interrupted, so it didn't bother with unwinding (which
doesn't come for free).





      parent reply	other threads:[~2021-08-12 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 16:04 bug#30529: 26.0.91; minibuffer errors change standard-output Francis Wright
2020-11-26 13:52 ` Lars Ingebrigtsen
2020-11-29 15:29   ` Basil L. Contovounesios
2020-11-30  9:41     ` Lars Ingebrigtsen
2021-08-12 14:34     ` Lars Ingebrigtsen
2021-08-12 15:04       ` Andreas Schwab
2021-08-13 11:22         ` Lars Ingebrigtsen
2021-08-12 15:58       ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lf56d594.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30529@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=f.j.wright@live.co.uk \
    --cc=francis.j.wright@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).