From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30529: 26.0.91; minibuffer errors change standard-output Date: Thu, 12 Aug 2021 18:58:31 +0300 Message-ID: <83lf56d594.fsf@gnu.org> References: <85po510xv9.fsf@gmail.com> <874klcql7u.fsf@gnus.org> <87360sdvwg.fsf@tcd.ie> <878s16k9zn.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29528"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, f.j.wright@live.co.uk, francis.j.wright@gmail.com, 30529@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 12 18:00:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mED8L-0007TW-52 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 18:00:41 +0200 Original-Received: from localhost ([::1]:56494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mED8J-0004yP-Vi for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 12:00:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mED7i-0004yG-JC for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 12:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mED7i-00032l-7E for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 12:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mED7i-00022z-49 for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 12:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Aug 2021 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30529 X-GNU-PR-Package: emacs Original-Received: via spool by 30529-submit@debbugs.gnu.org id=B30529.16287839437753 (code B ref 30529); Thu, 12 Aug 2021 16:00:02 +0000 Original-Received: (at 30529) by debbugs.gnu.org; 12 Aug 2021 15:59:03 +0000 Original-Received: from localhost ([127.0.0.1]:39788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mED6k-00020z-RG for submit@debbugs.gnu.org; Thu, 12 Aug 2021 11:59:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mED6h-00020S-BW for 30529@debbugs.gnu.org; Thu, 12 Aug 2021 11:59:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41956) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mED6Z-00029Z-8q; Thu, 12 Aug 2021 11:58:52 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mED6Y-0001Cp-JD; Thu, 12 Aug 2021 11:58:51 -0400 In-Reply-To: <878s16k9zn.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 12 Aug 2021 16:34:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211700 Archived-At: > From: Lars Ingebrigtsen > Date: Thu, 12 Aug 2021 16:34:20 +0200 > Cc: f.j.wright@live.co.uk, Francis Wright , > 30529@debbugs.gnu.org > > Found the culprit! cmd_error sets standard_output to t! > > The following patch fixes the reported issue (and doesn't lead to any > regressions in the test suite), but this code has been like this > forever, so I'm a bit leery about applying it. > > And perhaps the > > old_level = Vprint_level; > old_length = Vprint_length; > > stuff should also be changed to specbinding? Or do we want to avoid > specbind here totally for some reason? The commit for those lines just > says: > > (cmd_error): Bind Vprint_level and Vprint_length. > > I mean, we had specbind before 1995, I think? > > So... any comments/insights here? I see no problems with the patch. As we add calls into Lisp in more and more places in the internals, we hit code that never imagined it could be interrupted, so it didn't bother with unwinding (which doesn't come for free).