unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com
Subject: bug#49127: Performance degradation in encode_coding_object
Date: Mon, 16 Aug 2021 21:50:03 +0300	[thread overview]
Message-ID: <83lf516x7o.fsf@gnu.org> (raw)
In-Reply-To: <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> (message from Mattias Engdegård on Mon, 16 Aug 2021 20:06:32 +0200)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Mon, 16 Aug 2021 20:06:32 +0200
> Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org
> 
> > Yes.  Why do you think this loop is broken?
> 
> Because unless I misunderstood the code entirely, the current buffer has nothing to do with the operation at hand.

It does, if both src_object and dst_object are the same (current)
buffer.

> It's easy to reproduce the original problem: run Emacs in a terminal and make a buffer with many markers. See how the text displays slower with more markers. I've attached a short example; try (make-test-buffer 1000).

How can we be sure this reproduces the original issue?  The original
issue was reported from a real-life use case, not from a toy program.

> The attached patch fixes this problem.

Thanks, but this is not the whole story with that problem in
encode_coding_object.





  reply	other threads:[~2021-08-16 18:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <EC5DED64-8465-45A3-B20C-8D21F70E0A34@acm.org>
2021-08-16 17:43 ` bug#49127: Performance degradation in encode_coding_object Eli Zaretskii
2021-08-16 18:06   ` Mattias Engdegård
2021-08-16 18:50     ` Eli Zaretskii [this message]
2021-08-16 20:04       ` Mattias Engdegård
2021-08-17 12:34         ` Eli Zaretskii
2021-08-17 13:06           ` Mattias Engdegård
2021-08-17 14:05             ` Eli Zaretskii
2021-08-17 16:07               ` Mattias Engdegård
2021-08-17 17:16                 ` Eli Zaretskii
2021-08-18 11:04                   ` Mattias Engdegård
2021-08-18 11:43                     ` Eli Zaretskii
2021-08-18 12:21                       ` Mattias Engdegård
2021-08-18 13:23                         ` Eli Zaretskii
2021-08-18 13:32                           ` Mattias Engdegård
2021-08-18 13:39                             ` Eli Zaretskii
2021-08-18 13:54                               ` Mattias Engdegård
2021-08-18 13:59                                 ` Eli Zaretskii
2021-08-18 15:24                                   ` Mattias Engdegård
2021-08-18 14:34                             ` Lars Ingebrigtsen
2021-08-20 23:24                               ` Michael Welsh Duggan
2021-08-21  6:34                                 ` Eli Zaretskii
2021-06-20  6:30 Victor Nawothnig via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-20  9:04 ` Eli Zaretskii
2021-06-24 16:49   ` Eli Zaretskii
2021-07-25  7:10     ` Eli Zaretskii
2021-08-15 15:07       ` Eli Zaretskii
2021-08-17 12:35         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lf516x7o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=49127@debbugs.gnu.org \
    --cc=mattiase@acm.org \
    --cc=victor.nawothnig@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).