From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49127: Performance degradation in encode_coding_object Date: Mon, 16 Aug 2021 21:50:03 +0300 Message-ID: <83lf516x7o.fsf@gnu.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 16 20:51:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFhhV-0009I8-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 20:51:09 +0200 Original-Received: from localhost ([::1]:42144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFhhU-0002Zc-NI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 14:51:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFhhO-0002ZU-FP for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 14:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFhhO-000455-6r for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 14:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFhhO-0003pA-5N for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 14:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Aug 2021 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49127 X-GNU-PR-Package: emacs Original-Received: via spool by 49127-submit@debbugs.gnu.org id=B49127.162913982314644 (code B ref 49127); Mon, 16 Aug 2021 18:51:02 +0000 Original-Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 18:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:50980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFhgk-0003o7-WF for submit@debbugs.gnu.org; Mon, 16 Aug 2021 14:50:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFhgg-0003no-2w for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 14:50:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58324) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFhga-0003Go-DE; Mon, 16 Aug 2021 14:50:12 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4476 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFhgY-00022V-6D; Mon, 16 Aug 2021 14:50:12 -0400 In-Reply-To: <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 16 Aug 2021 20:06:32 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212060 Archived-At: > From: Mattias Engdegård > Date: Mon, 16 Aug 2021 20:06:32 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > > Yes. Why do you think this loop is broken? > > Because unless I misunderstood the code entirely, the current buffer has nothing to do with the operation at hand. It does, if both src_object and dst_object are the same (current) buffer. > It's easy to reproduce the original problem: run Emacs in a terminal and make a buffer with many markers. See how the text displays slower with more markers. I've attached a short example; try (make-test-buffer 1000). How can we be sure this reproduces the original issue? The original issue was reported from a real-life use case, not from a toy program. > The attached patch fixes this problem. Thanks, but this is not the whole story with that problem in encode_coding_object.